Skip to content

fix decchar handling in writecell() for AbstractFloat#1109

Merged
quinnj merged 4 commits intoJuliaData:mainfrom
sara2512:main
Oct 19, 2024
Merged

fix decchar handling in writecell() for AbstractFloat#1109
quinnj merged 4 commits intoJuliaData:mainfrom
sara2512:main

Conversation

@sara2512
Copy link
Copy Markdown
Contributor

@sara2512 sara2512 commented Aug 15, 2023

This PR fixes #1108.

Currently DecFP.Dec64 Floats are not handled correctly. Decimal character is not replaced.

using DecFP
using DataFrames
using CSV
io = IOBuffer() 
CSV.write(io, DataFrame(:a => Dec64(1)); decimal = ',')
String(take!(io))
# "a\n1.0\n"

With the PR in place the result is as expected.

CSV.write(io, DataFrame(:a => Dec64(1)); decimal = ',')
String(take!(io))
# "a\n1,0\n"

@codecov
Copy link
Copy Markdown

codecov bot commented Oct 19, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 55.55556% with 4 lines in your changes missing coverage. Please review.

Project coverage is 90.47%. Comparing base (80936af) to head (a05e45f).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/write.jl 55.55% 4 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1109      +/-   ##
==========================================
+ Coverage   90.27%   90.47%   +0.19%     
==========================================
  Files           9        9              
  Lines        2314     2319       +5     
==========================================
+ Hits         2089     2098       +9     
+ Misses        225      221       -4

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

quinnj
quinnj approved these changes Oct 19, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@quinnj quinnj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@quinnj quinnj merged commit e84bd71 into JuliaData:main Oct 19, 2024
quinnj added a commit that referenced this pull request Jan 12, 2026
@sara2512 @quinnj
fix decchar handling in writecell() for AbstractFloat (#1109)
72d8c31 
* fix decchar handling in writecell() for AbstractFloat

* test for #1109 fix decchar handling in writecell() for AbstractFloat

* fix newline format

---------

Co-authored-by: Jacob Quinn <quinn.jacobd@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@quinnj quinnj quinnj approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Keyword decimal not respected for AbstractFloats in CSV.write()

2 participants

@sara2512 @quinnj