Selectively reduce multithreaded parsing @error#1099
Merged
quinnj merged 1 commit intoJuliaData:mainfrom Jun 20, 2023
Merged
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #1099 +/- ##
==========================================
+ Coverage 90.40% 90.42% +0.01%
==========================================
Files 9 9
Lines 2294 2298 +4
==========================================
+ Hits 2074 2078 +4
Misses 220 220
☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reduce the
@errorintroduced in #1073 to a@warningwhenever previous warnings may explain why multithreaded parsing failed (typically, unequal number of columns per row). In those cases, it will print:If there is no possible explanation, this still shows a red
@errorsaying:In both cases, a debug statement is printed as soon as multithread parsing failed (if the Context
debugkwarg is set), whereas the@warningor@erroronly appears at the end of the fallback single-threaded parsing.I think this compromise allows us to still get error reports like #1095, which are crucial to detect and allow use to fix underlying issues where multithreaded parsing should not fail (like #1098 in this instance), while avoiding to stress the user with an
@errorwhen there is nothing to report.Close #1095.