This is an automated message.
Plots were compared to references. 11/11 images have changed, see differences below.
After pulling this PR, please update the reference images by creating a PR to ControlExamplePlots.jl here.

Difference	Reference Image	New Image
✔️ 0.004
❌ 0.048
⚠️ 0.016
✔️ 0.0
✔️ 0.002
✔️ 0.002
✔️ 0.003
✔️ 0.003
✔️ 0.01
✔️ 0.0
✔️ 0.011

Seems this added an extra print to the state space, which broke CI.

Easy to fix, but there are some options:

• Revert the print
• Remove a newline in the delayed print, update the ss tests
• Update all 5 tests

It seems we are a little inconsistent with how much whitespace is printed for different types. Before this change tf and ss was the same (1 space after) while delayed had 2 spaces. This change made ss also have 2 spaces, which also introduced 2 spaces inside delayed since it uses the ss print.

I feel like just having one space is easy and clear enough.

@baggepinnen was there any specific reason to introduce those extra newlines?

EDIT: the added commit reverts the print and updates the delayed to similar behaviour (my one space everywhere suggestion).

Codecov Report

❗ No coverage uploaded for pull request base (dev@c31d065). Click here to learn what that means.
The diff coverage is n/a.

@@          Coverage Diff           @@
##             dev     #555   +/-   ##
======================================
  Coverage       ?   85.08%           
======================================
  Files          ?       31           
  Lines          ?     3192           
  Branches       ?        0           
======================================
  Hits           ?     2716           
  Misses         ?      476           
  Partials       ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c31d065...f644db6. Read the comment docs.

The reason was that vectors of systems printed slightly weirdly without the change. Not a big deal though. I wonder why test pass on some Julia versions but not others.

The github CI shows pass on nightly even though it failed, since we have set it as allowed to fail (if that is what you were talking about).

Ah, it's perhaps not great that it signals green when the tests fail. I think travis would show that allowed subtests failed but report success on the overall test.
Eventually we should perhaps look over our print tests since they have historically broke several times and it's a hassle to update them every second julia release.

Ah, it's perhaps not great that it signals green when the tests fail. I think travis would show that allowed subtests failed but report success on the overall test.

Completely agree, remember this as something that was missing from github ci but maybe I'm wrong there.