Closed
Conversation
Merged
Contributor
|
If you want opinions, here is mine: I dont care much for supporting 1.0, especially at the cost of development-time. Also, if other important packages are dropping 1.0 support, users should be on the updated version of julia anyways. |
Contributor
|
Considering how much they have diverged, this makes sense, and there has been talk about 1.6 becoming the next LTS release so a new LTS probably isn't that far away (1.6 would go into LTS when they branch 1.7 is what I have heard). |
Member
|
Since #470 we now support 1.6 and up, so I assume we could now merge the other changes in this PR that removes some version specific code? |
Member
Author
|
Yep, sounds good |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR changes the compatibility of Julia to v1.5, instead of the previous 1.0. The motivation for this is that it takes too much developer effort to maintain support for old julia versions.
This would mean that we can also get rid of some ugly version-specific code in this package, and that tests will go a bit faster. This also gives us access to things like
mul!eachrow, eachcoletc.On the whole, I think most people would benefit from a faster development cycle rather than new features being added for those who linger on julia v1.0. This also appears to be the mindset of the rest of the ecosystem, most packages drop support for older versions without hesitation. Only well backed packages with lots of maintainers strive for compat with 1.0.
The following have all ditched 1.0 on the main branch
Failures on old Julia versions but not on latest: