Skip to content

Remove dependence on partial linear indexing#106

Merged
ararslan merged 2 commits intoJuliaCI:masterfrom
mbauman:patch-1
Aug 28, 2017
Merged

Remove dependence on partial linear indexing#106
ararslan merged 2 commits intoJuliaCI:masterfrom
mbauman:patch-1

Conversation

@mbauman
Copy link
Copy Markdown
Member

@mbauman mbauman commented Aug 24, 2017

Needed to test performance of JuliaLang/julia#21750.

@mbauman
Copy link
Copy Markdown
Member Author

mbauman commented Aug 24, 2017

Looks like I'll need to also update Compat...

@mbauman
Copy link
Copy Markdown
Member Author

mbauman commented Aug 24, 2017

This is now awaiting JuliaLang/Compat.jl#399.

@ararslan
Copy link
Copy Markdown
Member

You can bump Compat to 0.31.0 once JuliaLang/METADATA.jl#10949 is merged.

@ararslan
Copy link
Copy Markdown
Member

I've bumped the Compat dependency for you, but this will now need #107 in order to pass CI.

@ararslan ararslan closed this Aug 28, 2017
@ararslan ararslan reopened this Aug 28, 2017
@ararslan ararslan merged commit df62f0f into JuliaCI:master Aug 28, 2017
@ararslan
Copy link
Copy Markdown
Member

I'm retuning the Nanosoldier benchmarks now, and I'll trigger a new Nanosoldier run on your PR once that's done.

Keno pushed a commit that referenced this pull request Feb 4, 2022
* update ind(min|max) to arg(min|max)

* update uninitialized to undef

* fix using A.B deprecation warning for non-modules

* use Compat instead of VERSION-dancing

* contains(haystack, needle) -> occursin(needle, haystack)

* STDERR -> stderr
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants