Merged
Conversation
freakstatic
approved these changes
Nov 8, 2023
Collaborator
dobertRowneySr
left a comment
There was a problem hiding this comment.
It looks ok:
- the new extrinsics weight scale (
buy/sell_on_ammlooks plausible) - in the creator token
*-transferextrinsic the metadata parameter now is accounted for and possibly it dominates theoutputsize parameter
besides the metadata weight I don't have any other major remark
| Weight::from_parts(100_964_050, 0u64) | ||
| .saturating_add(Weight::from_parts(0, 20544)) | ||
| // Standard Error: 50_287 | ||
| .saturating_add(Weight::from_parts(11_041_181, 0u64).saturating_mul(o.into())) |
Collaborator
There was a problem hiding this comment.
Same here, the metadata seems to be accounted for now...
| // Standard Error: 67_129 | ||
| .saturating_add(Weight::from_parts(12_404_421, 0u64).saturating_mul(a.into())) | ||
| // Standard Error: 15_985 | ||
| .saturating_add(Weight::from_parts(1_124_562, 0u64).saturating_mul(b.into())) |
Collaborator
There was a problem hiding this comment.
I wonder why beforehand the metadata weight b wasn't even considered...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
┆Issue is synchronized with this Asana task by Unito