Conversation
zeeshanakram3
left a comment
There was a problem hiding this comment.
Looks good. Just a suggestion I think we should update the hydra dependencies at all places to v5.0.0-alpha.7 version, for consistency. As package.json files in query-node/* has older hydra dependencies. WDYT?
| # 5. start node | ||
| # 5. start node using new version | ||
| export JOYSTREAM_NODE_TAG=${TARGET_RUNTIME} | ||
| CONTAINER_ID=$(start_joystream_node) |
There was a problem hiding this comment.
The CONTAINER_ID variable is no longer used except for assignment here. I think it should be removed?
That might be a good idea, although those packages were not actually modified it doesn't hurt to keep them all at the same version to avoid any confusion about why they are different. |
Done in a8722d2 |
This version of hydra better handles indexing when runtime upgrade happens without the process exiting.
┆Issue is synchronized with this Asana task by Unito