Membership module refactoring#490
Merged
bedeho merged 15 commits intoJoystream:membership_cleanupfrom Jun 2, 2020
Merged
Conversation
- move all the code from the members mod to the lib.rs - update all dependencies
Make MemberIdsByRootAccountId and MemberIdsByControllerAccountId private in the membership module.
This was
linked to
issues
May 27, 2020
Closed
- remove roles from the membership module - remove roles from the content working group module - move ActorId from membership to the content working group - add MemberId to te content working group Lead - update tests - delete commented code
bedeho
requested changes
May 30, 2020
Contributor
Author
|
Several issues were created in order to remove |
Change call from ensure_is_controller_account_for_member() to the ensure_member_controller_account_signed().
bedeho
approved these changes
Jun 2, 2020
Closed
This was referenced May 24, 2021
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes