-
Notifications
You must be signed in to change notification settings - Fork 117
Cleanup membershp module #93
Copy link
Copy link
Closed
Labels
good first issueGood for newcomersGood for newcomersmembership-palletMembership runtime moduleMembership runtime moduletech-debtTechnical DebtTechnical Debt
Description
Both module storage and interface need to be cleaned up.
The storage and forum client modules need the old interface, and thus storage model, to work, so we have postponed.
- Drop storage fields
pub MemberIdsByRootAccountId get(member_ids_by_root_account_id) : map T::AccountId => Vec<T::MemberId>;
// Mapping of a controller account id to vector of member ids it controls
pub MemberIdsByControllerAccountId get(member_ids_by_controller_account_id) : map T::AccountId => Vec<T::MemberId>;and all modules that depend on them.
-
No method shall identify members through accounts, but we can have checker methods (return
bool) that can verify the validity of a provided account. -
Change
ProfiletoMembership, and storage fieldMemberProfiletoMembershipById. Its far less confusing. -
MembersCreated=>NextMemberId -
Handles=>MemberIdByHandle -
Drop
UserInfo, does nothing. -
Drop
Optionwrapper for around value types of maps, e.g.MemberProfile.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
good first issueGood for newcomersGood for newcomersmembership-palletMembership runtime moduleMembership runtime moduletech-debtTechnical DebtTechnical Debt