Skip to content

update changelogs#4743

Merged
mnaamani merged 1 commit intoJoystream:masterfrom
mnaamani:master-update-missing-changelog-entries
Apr 25, 2023
Merged

update changelogs#4743
mnaamani merged 1 commit intoJoystream:masterfrom
mnaamani:master-update-missing-changelog-entries

Conversation

@mnaamani
Copy link
Copy Markdown
Member

@mnaamani mnaamani commented Apr 24, 2023

Fixes #4714

@vercel
Copy link
Copy Markdown

vercel bot commented Apr 24, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated (UTC)
pioneer-testnet ⬜️ Ignored (Inspect) Apr 24, 2023 9:36am

@mnaamani mnaamani changed the title update changelogs for some packages missed during ephesus release update changelogs Apr 24, 2023
@mnaamani mnaamani requested a review from zeeshanakram3 April 24, 2023 09:37
zeeshanakram3
zeeshanakram3 reviewed Apr 24, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@zeeshanakram3 zeeshanakram3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, though there is a failing CI check for building joystream node images for runtime upgrade (apparently because pallet-utility could not be found during build process). Not sure why it's failing now?

@mnaamani
Copy link
Copy Markdown
Member Author

mnaamani commented Apr 24, 2023

Looks good, though there is a failing CI check for building joystream node images for runtime upgrade (apparently because pallet-utility could not be found during build process). Not sure why it's failing now?

I think it was a temporary network failure downloading some crates from crates.io
Re-running build job now, but even if that passes it will likely fail in the runtime-upgrade test ci check which I'm addressing in #4744

@mnaamani
Copy link
Copy Markdown
Member Author

mnaamani commented Apr 24, 2023

So the build issue is actually is deeper than I originally thought and will create a separate issue for it #4745

@mnaamani mnaamani merged commit 8e3b824 into Joystream:master Apr 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zeeshanakram3 zeeshanakram3 zeeshanakram3 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Ephesus: Missing CHANGELOG entries

2 participants

@mnaamani @zeeshanakram3