Skip to content

Bumped hydra dependencies in QN #4616

Merged
Lezek123 merged 3 commits intoJoystream:masterfrom
zeeshanakram3:bumpHydraDepencencies
Feb 14, 2023
Merged

Bumped hydra dependencies in QN #4616
Lezek123 merged 3 commits intoJoystream:masterfrom
zeeshanakram3:bumpHydraDepencencies

Conversation

@zeeshanakram3
Copy link
Copy Markdown
Contributor

@zeeshanakram3 zeeshanakram3 commented Feb 9, 2023

This PR:

@vercel
Copy link
Copy Markdown

vercel bot commented Feb 9, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated
pioneer-testnet ⬜️ Ignored (Inspect) Feb 14, 2023 at 6:45AM (UTC)

@mnaamani
Copy link
Copy Markdown
Member

mnaamani commented Feb 9, 2023

LGTM, I'm syncing a new query node instance against mainnet to confirm there are no isssues.

@mnaamani
Copy link
Copy Markdown
Member

mnaamani commented Feb 10, 2023

I deployed this fix to mainnet production QN
cc: @thesan

@mnaamani
Copy link
Copy Markdown
Member

mnaamani commented Feb 10, 2023

@zeeshanakram3 needs minor conflict fix since we bumped the metadata protobuf package version
"@joystream/metadata-protobuf": "^2.5.1",

Lezek123
Lezek123 reviewed Feb 13, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@Lezek123 Lezek123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but since we already started bumping QN versions, I think you should bump query-node and query-node/mappings version in this PR aswell.

@mnaamani mnaamani mentioned this pull request Feb 13, 2023
Merged
@mnaamani
Copy link
Copy Markdown
Member

mnaamani commented Feb 13, 2023

Looks good, but since we already started bumping QN versions, I think you should bump query-node and query-node/mappings version in this PR aswell.

Yes let bump it to 1.0.0 - ref #4607 @zeeshanakram3

@zeeshanakram3
Copy link
Copy Markdown
Contributor Author

zeeshanakram3 commented Feb 14, 2023

Looks good, but since we already started bumping QN versions, I think you should bump query-node and query-node/mappings version in this PR aswell.

Yes let bump it to 1.0.0 - ref #4607 @zeeshanakram3

Bumped both packages' versions to 1.0.0 in 4ed7414
@mnaamani @Lezek123

Lezek123
Lezek123 approved these changes Feb 14, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@Lezek123 Lezek123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Lezek123 Lezek123 merged commit fb51950 into Joystream:master Feb 14, 2023
@Lezek123 Lezek123 mentioned this pull request Feb 21, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mnaamani mnaamani mnaamani approved these changes

+1 more reviewer

@Lezek123 Lezek123 Lezek123 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@zeeshanakram3 @mnaamani @Lezek123