bump package versions for ephesus by mnaamani · Pull Request #4607 · Joystream/joystream

mnaamani · 2023-02-07T16:13:16Z

Bump package versions to be higher than master branch.

┆Issue is synchronized with this Asana task by Unito

vercel · 2023-02-07T16:13:20Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment

Name	Status	Preview	Comments	Updated
pioneer-testnet	⬜️ Ignored (Inspect)			Feb 21, 2023 at 0:07AM (UTC)

dobertRowneySr

LGTM

zeeshanakram3

Shouldn't we also bump query-node version? Here is the list of all versions we selected for ephesus release

After Joystream/hydra#516 has been merged, and new hydra version released, we should also update the hydra dependencies in the QN

mnaamani · 2023-02-08T12:32:46Z

Shouldn't we also bump query-node version? Here is the list of all versions we selected for ephesus release

Thank you I was looking for this to cross check. Will revise to match.

After Joystream/hydra#516 has been merged, and new hydra version released, we should also update the hydra dependencies in the QN

Noted

mnaamani · 2023-02-08T12:35:11Z

There are a couple of PRs updating joystream-js package, so I assume that will need to be bumped also and published to npm eventually? @zeeshanakram3

zeeshanakram3 · 2023-02-08T15:08:54Z

There are a couple of PRs updating joystream-js package, so I assume that will need to be bumped also and published to npm eventually? @zeeshanakram3

I talked to Theo about the PR that he created, and he said that merging it is not important as they have found workaround for it. The other one should be merged I believe as this will be required for Apps. So yes, newer version of joystream-js package should be published to npm

Lezek123 · 2023-02-10T14:22:41Z

cli/package.json

  "name": "@joystream/cli",
  "description": "Command Line Interface for Joystream community and governance activities",
-  "version": "0.10.0",
+  "version": "0.11.0",


I'm wondering if we should bump versions of all packages that still start with 0. to 1. now that we're on mainnet,

I have no objection.

1.0.0 - mainnet
1.1.0 - apps
1.20 - ephesus

@Lezek123

If you mean 1.2.0 for Ephesus then sounds good.

yep, typo there :)

Lezek123 · 2023-02-10T14:25:35Z

tests/network-tests/package.json

    "@apollo/client": "^3.2.5",
    "@joystream/distributor-node-client": "^0.2.0",
-    "@joystream/types": "^0.20.6",
+    "@joystream/types": "^0.20.7",


Same comment as w.r.t. @joystream/cli, it looks strange to not have the patch version at all and only update the minor one during a new release.

So we go for 0.21.0 for ephesus, unless we want to also start at 1.0.0 for mainnet, so making ephesus version 1.1.0 (as there are no runtime changes for apps release)

I think we should start at 1.0.0 for mainnet for consistency

Lezek123 · 2023-02-10T14:31:37Z

cli/package.json

    "@ffprobe-installer/ffprobe": "^1.4.1",
-    "@joystream/metadata-protobuf": "^2.5.0",
-    "@joystream/types": "^0.20.6",
+    "@joystream/metadata-protobuf": "^2.7.0",


There will be apps release before ephesus and 2.6.0 is already taken, so I think 2.7.0 should be the apps and 2.8.0 - Ephesus?

That's a sensible suggestion.

Lezek123 · 2023-02-10T14:34:09Z

query-node/mappings/package.json

 {
  "name": "query-node-mappings",
-  "version": "0.1.0",
+  "version": "1.0.0",


Another question is whether we should bump the major version already for the apps release or for Ephesus? Otherwise we'd have to use something like 0.1.2 for the apps release.

Sounds good to me. With reference to bumping version on master #4616 (review) lets make it
1.0.0 for master branch,
1.1.0 for apps release,
1.2.0 for ephesus?

Sounds good! 👍

mnaamani · 2023-02-14T09:40:00Z

Bumped versions to also take into consideration incoming PR to master #4560

Lezek123

CLI/network-tests should depend on @joystream/js of version at least 1.3.0 (currently ^1.0.0)
W.r.t. @joystream/types, I think the combination of using ^1.1.0 and bumping only the minor version during an upgrade like Ephesus is risky. We should probably either bump the major version when there are non-backward-compatible changes (like the removal of sudo pallet, changes in existing event parameters etc.) or use ~1.1.0 to avoid some of our apps using non-compatible version of @joystream/types in the future.

mnaamani · 2023-02-21T11:53:27Z

CLI/network-tests should depend on @joystream/js of version at least 1.3.0 (currently ^1.0.0)

W.r.t. @joystream/types, I think the combination of using ^1.1.0 and bumping only the minor version during an upgrade like Ephesus is risky. We should probably either bump the major version when there are non-backward-compatible changes (like the removal of sudo pallet, changes in existing event parameters etc.) or use ~1.1.0 to avoid some of our apps using non-compatible version of @joystream/types in the future.

Well spotted
That is a good point. Going with 2.0.0 sounds best.

mnaamani · 2023-02-21T12:10:39Z

Updated as suggested. You will note I had to bump the dependency in migration-scripts as well, although that set of migration scripts should all be dropped, in addition to some in api-scripts as they depend on sudo. I will prepare a separate PR for that.

Lezek123

LGTM

bump packages version for ephesus

ab11871

mnaamani requested review from Lezek123 and zeeshanakram3 February 7, 2023 16:13

mnaamani added the ephesus label Feb 7, 2023

mnaamani changed the title ~~bump packages version for ephesus~~ bump package versions for ephesus Feb 7, 2023

mnaamani requested a review from dobertRowneySr February 7, 2023 17:17

dobertRowneySr approved these changes Feb 7, 2023

View reviewed changes

zeeshanakram3 reviewed Feb 8, 2023

View reviewed changes

zeeshanakram3 mentioned this pull request Feb 8, 2023

update @joystream/cli README #4610

Merged

sync-by-unito bot assigned mnaamani Feb 8, 2023

bump query-node version to final for ephesus release

8637e8e

mnaamani requested a review from zeeshanakram3 February 8, 2023 14:19

Lezek123 reviewed Feb 10, 2023

View reviewed changes

mnaamani mentioned this pull request Feb 13, 2023

Bumped hydra dependencies in QN #4616

Merged

mnaamani added 3 commits February 13, 2023 20:45

Merge branch 'ephesus' into ephesus-bump-package-version

ffc06bf

final ephesus package versions

1540b9d

bump storage-node to v3.2.0

c3b61ff

mnaamani requested a review from Lezek123 February 14, 2023 09:54

sync-by-unito bot closed this Feb 14, 2023

mnaamani reopened this Feb 16, 2023

mnaamani mentioned this pull request Feb 20, 2023

Ephesus Update from master #4649

Closed

mnaamani added 3 commits February 20, 2023 12:31

Merge branch 'ephesus' into ephesus-bump-package-version

4ed5266

Merge branch 'ephesus' into ephesus-bump-package-version

2dfa928

prettier fix

39b52bc

Lezek123 suggested changes Feb 21, 2023

View reviewed changes

bump types version to 2.0.0 and dependency on joystream/js to 1.3.0

f5276ac

Lezek123 approved these changes Feb 21, 2023

View reviewed changes

mnaamani mentioned this pull request Feb 21, 2023

Update versions in Ephesus release plan #4651

Closed

mnaamani merged commit 8abfb11 into Joystream:ephesus Feb 21, 2023

Conversation

mnaamani commented Feb 7, 2023 • edited by sync-by-unito bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

vercel bot commented Feb 7, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dobertRowneySr left a comment

Choose a reason for hiding this comment

Uh oh!

zeeshanakram3 left a comment

Choose a reason for hiding this comment

Uh oh!

mnaamani commented Feb 8, 2023

Uh oh!

mnaamani commented Feb 8, 2023

Uh oh!

zeeshanakram3 commented Feb 8, 2023

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mnaamani Feb 13, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mnaamani commented Feb 14, 2023

Uh oh!

Lezek123 left a comment

Choose a reason for hiding this comment

Uh oh!

mnaamani commented Feb 21, 2023

Uh oh!

mnaamani commented Feb 21, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Lezek123 left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

mnaamani commented Feb 7, 2023 •

edited by sync-by-unito bot

Loading

vercel bot commented Feb 7, 2023 •

edited

Loading

mnaamani Feb 13, 2023 •

edited

Loading

mnaamani commented Feb 21, 2023 •

edited

Loading