expose QN status in Argus and Colossus#4560
Merged
Lezek123 merged 8 commits intoJoystream:masterfrom Feb 16, 2023
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
This was referenced Jan 24, 2023
Lezek123
suggested changes
Jan 24, 2023
Contributor
Lezek123
left a comment
There was a problem hiding this comment.
Some additional notes:
- Comments apply to both Argus and Colossus
- When testing locally with
query-nodebeing shut down, going to http://localhost:3334/api/v1/status results in the requesting hanging forever - Version bumps are needed for both Argus and Colossus (Argus should probably be updated to
1.0.0now that we're on mainnet) CHANGELOG.mdshould be updated for both Argus and Colossus
distributor-node/src/services/networking/query-node/queries/queries.graphql
Outdated
Show resolved
Hide resolved
mnaamani
requested changes
Feb 3, 2023
Member
mnaamani
left a comment
There was a problem hiding this comment.
In addition to points raised by Leszek, we can re-target this feature to master branch for early release. So please bump the version of argus and colossus as well.
37d6fb6 to
a99e90e
Compare
Member
|
needs a merge conflict fix @zeeshanakram3 |
…_status_in_argus_and_colossus
Contributor
Author
Addressed in 548cf9c |
Lezek123
suggested changes
Feb 15, 2023
Contributor
Lezek123
left a comment
There was a problem hiding this comment.
Since the PR affects the API, Please bump the versions in:
storage-node/client/package.jsondistributor-node/client/package.json
(they should match the current version of the nodes)
8b861ee to
1d16423
Compare
1d16423 to
e545d72
Compare
This was referenced Feb 20, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses
┆Issue is synchronized with this Asana task by Unito