typegen: generate all schemas#4425
Merged
mnaamani merged 2 commits intoJoystream:carthagefrom Nov 7, 2022
Merged
Conversation
Member
mnaamani
commented
Nov 7, 2022
- updated chain metadata, ran yarn bulid in types packages
- ran yarn generate:all in cli,tests,storage and distributor node packages.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
Lezek123
approved these changes
Nov 7, 2022
Contributor
There was a problem hiding this comment.
LGTM, there is a small diff in /distributor-node/src/services/networking/storage-node/generated/api.ts, but it doesn't have any effect, since the distributor node is not using this api method and it will be fixed anyway by #4407
Member
Author
Nice that you caught that, although the integration tests don't cover colossus and argus api, if anything had broken it would have been caught by the linter I presume. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.