Carthage/mainnet runtime parameters by Lezek123 · Pull Request #4341 · Joystream/joystream

Lezek123 · 2022-10-05T15:03:00Z

Implements runtime parameters according to #4300 (proposal + discussion).

Monthly budget estimation for council: $660,000

Notable changes

Reward curve's max_piece_count parameter was set to 40 instead of 100, as the value of 100 was causing one of the tests to fail with Generated reward curve approximation is invalid: has more points than specified.
RuntimeUpgradeWasmProposalMaxLength was set to 3 MB instead of 3.5 MB, as mega_bytes macro doesn't support float values

Missing parameter values

Those parameter values were not included in the original proposal:

`content`

    pub const MaxNumberOfAssetsPerChannel: MaxNumber = 10;
    pub const MaxNumberOfAssetsPerVideo: MaxNumber = 20;
    pub const MaxNumberOfCollaboratorsPerChannel: MaxNumber = 10;

`storage`

 pub const MaxNumberOfOperatorsPerDistributionBucket: u32 = 20;

`forum`

Note that the proposal assumes #4275 has been addressed, but it's not the case yet, so I left some of the values untouched, ie.:

    pub const MaxSubcategories: u64 = 40;
    pub const MaxThreadsInCategory: u64 = 20;
    pub const MaxPostsInThread: u64 = 20;

There is also one new value that was introduced recently:

pub const MaxStickiedThreads: u32 = 20;

Current fees (examples)

Disclaimer: I was using the current weights, obviously the fees will be impacted once we re-generate weights using a proper setup.

`addForumPost`

`addVideoComment`

`buyMembership`

`createChannel`

`createForumThread`

`createVideo`

`deleteChannel`

`deleteForumPost`

`deleteForumThread`

`deleteVideo`

┆Issue is synchronized with this Asana task by Unito

vercel · 2022-10-05T15:25:47Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment

Name	Status	Preview	Updated
pioneer-testnet	⬜️ Ignored (Inspect)		Oct 8, 2022 at 6:26PM (UTC)

bedeho

Fantastic job!

Fees are a tad high, but it looks acceptable, thanks again for making this tool, it really makes a tremendous end-of-the-day sanity check.
The automated fees were just fantastic. I'm slightly nervous about them not being const but I think it's worth it, I also secretly don't quite believe this actually breaks anything despite Parity saying so :D.
I think it would be great if we could try to isolate a few of these literal values, in particular tests, into named constants, so there is some separate space for comments and just more maintainable.

runtime-modules/membership/src/lib.rs

runtime/src/lib.rs

runtime/src/utils.rs

bedeho · 2022-10-06T19:34:42Z

runtime/src/utils.rs

+use sp_std::mem::size_of;
+
+/// Compute total fee for executing a call
+pub fn compute_fee(call: Call) -> Balance {


This implementation looks right, but how did you arrive at this? did you extract the core logic of some other routines?

So initially I was thinking about using TransactionPayment::compute_fee approach as described in #4300, but it had a few major drawbacks:

The main issue was that it was reading a storage value (fee multiplier) which meant the result would change depending on it. This was very risky, because the runtime constants shouldn't change.

It didn't work for genesis config values, only for the pallet's Config trait parameters

So I implemented the logic of TransactionPayment::compute_fee in this function while disregarding the fee multiplier (so assuming it's 1). The formula for inclusion fee is quite simple as it's just:

inclusion_fee = base_fee + length_fee + [targeted_fee_adjustment * weight_fee];

Source: https://docs.rs/pallet-transaction-payment/3.0.0/pallet_transaction_payment/

So if we disregard targeted_fee_adjustment (fee multiplier), it's:

inclusion_fee = base_fee + length_fee + weight_fee;

runtime/src/utils.rs

runtime/src/constants.rs

runtime/src/lib.rs

bedeho · 2022-10-06T21:39:08Z

runtime/src/lib.rs

-    pub const MaxThreadsInCategory: u64 = 20;
-    pub const MaxPostsInThread: u64 = 20;
-    pub const MaxModeratorsForCategory: u64 = 20;
+    pub const MaxSubcategories: u64 = 40; // TODO: adjust


Why are there TODOs here?

It's explained in the PR description. It's because #4275 is not yet implemented, but the #4300 proposal assumes it is

4275 is now implemented by Ignazio in #4352

Lezek123 · 2022-10-07T12:53:09Z

Fees are a tad high, but it looks acceptable

The considerable part of the cost of channel/video creation is a result of StorageDepositCleanupProfit being set to 1 cent, which means all bloat bonds (including data object bloat bond) are 1 cent higher than they really need to be.
For example, when creating a video with 3 assets (thumbnail + media + subtitles), the additional 4 cents are a result of StorageDepositCleanupProfit alone (video_bloat_bond + 3 * data_object_bloat_bond).

When it comes to inclusion fees, most of the cost is weight-driven. Notice in case of channels and videos we're using a worst case scenario number of storage/distribution buckets, the actual numbers may be much lower.

I'm slightly nervous about them not being const

I think this is not a problem as long as the function that computes them doesn't depend on anything that may change over time. Currently the only way to make those functions (like compute_fee / compute_single_bloat_bond etc.) return different results would be to modify the runtime code. So they are constant in a sense, they are just not defined as constant functions.

Set mainnet parameters

d1c5d8f

Lezek123 marked this pull request as draft October 5, 2022 15:03

Lezek123 marked this pull request as ready for review October 5, 2022 15:04

Lezek123 changed the base branch from carthage to carthage-weights-gen October 5, 2022 15:17

Lezek123 changed the base branch from carthage-weights-gen to carthage October 5, 2022 15:17

Re-trigger CI checks

66888f7

Lezek123 requested review from bedeho and mnaamani October 5, 2022 15:26

Fix benchmarks and staging/testing profile builds

846281a

bedeho approved these changes Oct 6, 2022

View reviewed changes

Lezek123 added 3 commits October 7, 2022 00:50

Fix council testing config

6a88af6

Joystream#4341 review comments + benchmarking fixes

2adcc04

Update chain metadata

756bc5c

Lezek123 added 2 commits October 7, 2022 19:55

Fix CI checks

292b5b1

Fix benchmarks and integration tests

d10b11a

Lezek123 added the carthage label Oct 10, 2022

mnaamani approved these changes Oct 10, 2022

View reviewed changes

This was referenced Oct 10, 2022

Reduce minimum cleanup profit for data objects #4359

Closed

Benchmarks should always panic on failure #4361

Open

Lezek123 merged commit bbffff6 into Joystream:carthage Oct 10, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Carthage/mainnet runtime parameters#4341

Carthage/mainnet runtime parameters#4341
Lezek123 merged 8 commits intoJoystream:carthagefrom
Lezek123:carthage-mainnet-params

Lezek123 commented Oct 5, 2022 •

edited by sync-by-unito bot

Loading

Uh oh!

vercel bot commented Oct 5, 2022 •

edited

Loading

Uh oh!

bedeho left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

bedeho Oct 6, 2022

Uh oh!

Lezek123 Oct 7, 2022 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

bedeho Oct 6, 2022

Uh oh!

Lezek123 Oct 7, 2022

Uh oh!

mnaamani Oct 10, 2022

Uh oh!

Lezek123 commented Oct 7, 2022 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

Lezek123 commented Oct 5, 2022 • edited by sync-by-unito bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Notable changes

Missing parameter values

content

storage

forum

Current fees (examples)

addForumPost

addVideoComment

buyMembership

createChannel

createForumThread

createVideo

deleteChannel

deleteForumPost

deleteForumThread

deleteVideo

Uh oh!

vercel bot commented Oct 5, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bedeho left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

bedeho Oct 6, 2022

Choose a reason for hiding this comment

Uh oh!

Lezek123 Oct 7, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

bedeho Oct 6, 2022

Choose a reason for hiding this comment

Uh oh!

Lezek123 Oct 7, 2022

Choose a reason for hiding this comment

Uh oh!

mnaamani Oct 10, 2022

Choose a reason for hiding this comment

Uh oh!

Lezek123 commented Oct 7, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Lezek123 commented Oct 5, 2022 •

edited by sync-by-unito bot

Loading

`content`

`storage`

`forum`

`addForumPost`

`addVideoComment`

`buyMembership`

`createChannel`

`createForumThread`

`createVideo`

`deleteChannel`

`deleteForumPost`

`deleteForumThread`

`deleteVideo`

vercel bot commented Oct 5, 2022 •

edited

Loading

Lezek123 Oct 7, 2022 •

edited

Loading

Lezek123 commented Oct 7, 2022 •

edited

Loading