Merged
Conversation
b87b04c to
5f4aaa9
Compare
fcescob
reviewed
Nov 9, 2020
fcescob
left a comment
There was a problem hiding this comment.
Some minor things to fix, but good job! Managing the Placeholders and the VideoPreview is not easy
bedeho
approved these changes
Nov 9, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This one resolves #1605 and #1583 - it adds loaders based on placeholders for the following views:
It's based on #1618 so probably makes sense to review that one first, although it shouldn't bee too hard to review either way.
There are 2 issues: