Skip to content

add loading states#1643

Merged
bedeho merged 3 commits intoJoystream:init_atlasfrom
kdembler:atlas-loading-states
Nov 9, 2020
Merged

add loading states#1643
bedeho merged 3 commits intoJoystream:init_atlasfrom
kdembler:atlas-loading-states

Conversation

@kdembler
Copy link
Copy Markdown
Collaborator

@kdembler kdembler commented Nov 3, 2020

This one resolves #1605 and #1583 - it adds loaders based on placeholders for the following views:

  • video playback
  • channel
  • search

It's based on #1618 so probably makes sense to review that one first, although it shouldn't bee too hard to review either way.

There are 2 issues:

Screenshot 2020-11-03 at 8 04 06 PM

  • In the video view, once the video metadata finishes loading and the placeholder is hidden, the player goes to 0 height for a brief moment. I've tried a couple of things and I'm not sure how to solve it so left it for now. I will come back to this and possibly consult @Gamaranto on what we could do

@kdembler kdembler requested a review from fcescob November 3, 2020 19:34
@kdembler kdembler added the atlas label Nov 3, 2020
@kdembler kdembler force-pushed the atlas-loading-states branch from b87b04c to 5f4aaa9 Compare November 8, 2020 17:18
Copy link
Copy Markdown

@fcescob fcescob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor things to fix, but good job! Managing the Placeholders and the VideoPreview is not easy

Copy link
Copy Markdown

@fcescob fcescob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bedeho bedeho merged commit 641be93 into Joystream:init_atlas Nov 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants