Skip to content

channels responsive improvements#1618

Merged
bedeho merged 1 commit intoJoystream:init_atlasfrom
kdembler:atlas-channel-title
Nov 6, 2020
Merged

channels responsive improvements#1618
bedeho merged 1 commit intoJoystream:init_atlasfrom
kdembler:atlas-channel-title

Conversation

@kdembler
Copy link
Copy Markdown
Collaborator

@kdembler kdembler commented Oct 27, 2020

Resolves #1603 and #1604

@kdembler kdembler requested a review from fcescob October 27, 2020 14:09
@kdembler kdembler added the atlas label Oct 27, 2020
@kdembler kdembler force-pushed the atlas-channel-title branch from 4dac788 to 75e369b Compare November 2, 2020 17:30
@kdembler
Copy link
Copy Markdown
Collaborator Author

kdembler commented Nov 2, 2020

@Gamaranto rebased on top of the Glider.js changes. There's one issue though - because the ChannelPreview doesn't have a specified width now, it will grow to take the full row inside the carousel. I think this is the same kind of problem as with the VideoPreview and will be fixed by your other responsiveness changes, right?

@fcescob
Copy link
Copy Markdown

fcescob commented Nov 2, 2020

@Gamaranto rebased on top of the Glider.js changes. There's one issue though - because the ChannelPreview doesn't have a specified width now, it will grow to take the full row inside the carousel. I think this is the same kind of problem as with the VideoPreview and will be fixed by your other responsiveness changes, right?

Yes, you are correct, it will be fixed in the responsiveness changes.

@kdembler kdembler mentioned this pull request Nov 3, 2020
Merged
@kdembler kdembler force-pushed the atlas-channel-title branch from 75e369b to aed9b99 Compare November 6, 2020 12:03
fcescob
fcescob approved these changes Nov 6, 2020
View reviewed changes
Copy link
Copy Markdown

@fcescob fcescob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@bedeho bedeho merged commit 57a76f0 into Joystream:init_atlas Nov 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bedeho bedeho bedeho approved these changes

+1 more reviewer

@fcescob fcescob fcescob approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kdembler @fcescob @bedeho