Merged
Conversation
Time based id causes repetition in loops
eldiegod
commented
Mar 10, 2021
Contributor
Author
|
@kdembler I think all we talked about should be addressed in the last commits, as a note: |
kdembler
reviewed
Mar 23, 2021
Co-authored-by: Klaudiusz Dembler <accounts@kdembler.com>
…to my-videos-view
Contributor
Author
|
Waiting for illustration from designer |
kdembler
reviewed
Mar 23, 2021
Co-authored-by: Klaudiusz Dembler <accounts@kdembler.com>
…to my-videos-view
Contributor
Author
|
@kdembler merged the PR and tweaked the read fn a bit, looks good |
kdembler
approved these changes
Mar 23, 2021
Contributor
kdembler
left a comment
There was a problem hiding this comment.
90 commits, 90 comments PR, that's something. Great job 🥇
kdembler
added a commit
to kdembler/atlas
that referenced
this pull request
May 24, 2021
* wip * Pagination * Smooth pagination * Fix videoPreview Story * fix annoying glider lint warning * pagination onMouseEnter * fix types * Context menu callbacks * Draft message * Use random Id Time based id causes repetition in loops * Fix drafts type of any * Consistency with query node api * Draft test * Testing drafts rough * Remove draft feature * Channel dependant drafts * Draft logic * Make action bar fit the layout * Action bar * Cleaning hooks * Videos title not clickable when selecting * Video count from useVideos hook * Styles * Fixing queries * Video count query tweaks * moving folder * placeholder studio routing * cache * Draft provider around studio routes * isPublic query * Get all drafts from storage filter by channelId on return * fix query * Glider lint warning * Code review feedback and design updates * Pullup logic * Allow to fetch videos by publicness * Empty my videos screen * Studio layout * Component cleanup * Less videos per row * Fix video not fading in when swtiching categories on videos view * todo list * fix router * Cache pagination * Fetch fn * Mocked videos have isPublic field * staging channel id * No videos view * Trigger build * Cache and pagination * No videos uncomment * Unneeded styles * 4 rows of videos * Props * Capitalization * Uneeded styles * Empty videos view improvements * feedback * Dont forget about the drafts * HasAnyVideo var * Feedback * fc * wip preview transition * 0 index bases pagination * Offset limit pagination wip fix * CR fixes * Update src/views/studio/MyVideosView/MyVideosView.tsx Co-authored-by: Klaudiusz Dembler <accounts@kdembler.com> * cr * Has no videos var * useVideosPage * styles * Illustration empty videos view * Dont query when video is draft * Update src/views/studio/MyVideosView/MyVideosView.tsx Co-authored-by: Klaudiusz Dembler <accounts@kdembler.com> * cr * handle error * fix pagination (#1) * Videos read, type and edge case Co-authored-by: Klaudiusz Dembler <dev@kdembler.com> Co-authored-by: Klaudiusz Dembler <accounts@kdembler.com>
kdembler
added a commit
that referenced
this pull request
May 26, 2021
* wip * Pagination * Smooth pagination * Fix videoPreview Story * fix annoying glider lint warning * pagination onMouseEnter * fix types * Context menu callbacks * Draft message * Use random Id Time based id causes repetition in loops * Fix drafts type of any * Consistency with query node api * Draft test * Testing drafts rough * Remove draft feature * Channel dependant drafts * Draft logic * Make action bar fit the layout * Action bar * Cleaning hooks * Videos title not clickable when selecting * Video count from useVideos hook * Styles * Fixing queries * Video count query tweaks * moving folder * placeholder studio routing * cache * Draft provider around studio routes * isPublic query * Get all drafts from storage filter by channelId on return * fix query * Glider lint warning * Code review feedback and design updates * Pullup logic * Allow to fetch videos by publicness * Empty my videos screen * Studio layout * Component cleanup * Less videos per row * Fix video not fading in when swtiching categories on videos view * todo list * fix router * Cache pagination * Fetch fn * Mocked videos have isPublic field * staging channel id * No videos view * Trigger build * Cache and pagination * No videos uncomment * Unneeded styles * 4 rows of videos * Props * Capitalization * Uneeded styles * Empty videos view improvements * feedback * Dont forget about the drafts * HasAnyVideo var * Feedback * fc * wip preview transition * 0 index bases pagination * Offset limit pagination wip fix * CR fixes * Update src/views/studio/MyVideosView/MyVideosView.tsx Co-authored-by: Klaudiusz Dembler <accounts@kdembler.com> * cr * Has no videos var * useVideosPage * styles * Illustration empty videos view * Dont query when video is draft * Update src/views/studio/MyVideosView/MyVideosView.tsx Co-authored-by: Klaudiusz Dembler <accounts@kdembler.com> * cr * handle error * fix pagination (#1) * Videos read, type and edge case Co-authored-by: Klaudiusz Dembler <dev@kdembler.com> Co-authored-by: Klaudiusz Dembler <accounts@kdembler.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Figma: https://www.figma.com/file/rBjfm2tJ2Pr9M0UNTduU9v/Joystream-Atlas?node-id=3079%3A2721
issues: #282 / #365