Skip to content

⏪ Claim reward flow#3476

Merged
kdembler merged 5 commits intoJoystream:paymentsfrom
WRadoslaw:feature/claim-reward-flow
Dec 7, 2022
Merged

⏪ Claim reward flow#3476
kdembler merged 5 commits intoJoystream:paymentsfrom
WRadoslaw:feature/claim-reward-flow

Conversation

@WRadoslaw
Copy link
Copy Markdown
Contributor

@WRadoslaw WRadoslaw commented Dec 3, 2022

fixes #3053

@WRadoslaw WRadoslaw requested a review from drillprop December 3, 2022 08:01
@WRadoslaw
Copy link
Copy Markdown
Contributor Author

WRadoslaw commented Dec 6, 2022

I noticed that there is an error from PR implementing theuseChannelPayout hook. In handleTransaction cumulativeRewardClaimed was passed instead of cumulativeRewardEarned.

After the fix, the error occurred in OverviewTab, it looks like we have to validate the amount before displaying Claim button (or disable it with a tooltip informing what's going on).

image

@drillprop drillprop mentioned this pull request Dec 7, 2022
Closed
1 task
drillprop
drillprop approved these changes Dec 7, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@drillprop drillprop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed that there is an error from PR implementing theuseChannelPayout hook. In handleTransaction cumulativeRewardClaimed was passed instead of cumulativeRewardEarned.

After the fix, the error occurred in OverviewTab, it looks like we have to validate the amount before displaying Claim button (or disable it with a tooltip informing what's going on).

image

I created #3495 to fix this in the future.

Besides that, looks good to me!

@kdembler kdembler merged commit ad57dbf into Joystream:payments Dec 7, 2022
kdembler pushed a commit that referenced this pull request Dec 14, 2022
@WRadoslaw @kdembler
⏪ Claim reward flow (#3476)
0e9085a 
fixes #3053
@WRadoslaw WRadoslaw deleted the feature/claim-reward-flow branch December 23, 2022 09:20
drillprop pushed a commit that referenced this pull request Dec 28, 2022
@WRadoslaw @drillprop
⏪ Claim reward flow (#3476)
4e7dbb6 
fixes #3053
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@drillprop drillprop drillprop approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@WRadoslaw @drillprop @kdembler