Conversation
…n.js. Updated folder name at echarts4r/inst/htmlwidgets/lib/echarts-6.0.0 to represent the new echarts version. Both added new languages/themes and updated old ones in echarts4r/inst/htmlwidgets/lib/echarts-6.0.0/themes and echarts4r/inst/htmlwidgets/lib/echarts-6.0.0/i18n
…o generate new axis break zigzags.
…atter plots. Fixed error in e_scatter_() that resulted in a failed dplyr::select() if your data column names are x or y.
|
Oh awesome! I'll close my PR and work from yours! |
|
I'm working on adding the new chart types - I started the violin and I see you did the doughnut. We could also add wrappers to dplyr::select to remove those pesky warnings. I have my own PR forked from yours - also my first PR! Feel free to shoot me an email: jacciziebert@gmail.com |
Combined 675
…rts4r into prekieta_bump_V6
…d to solve issue JohnCoene#592. Added additional functions to pkgdown.yml
…rts4r into prekieta_bump_V6
…pages. Started work on a Matrix vignette.
…rts4r into prekieta_bump_V6
…nd quarto rendering.
…tte. Added chord chart type to chart_types vignette.
|
@jacciz @patrekieta apologies I've been so quiet on this. Thank you very much for all the work you've done. Do you have a summary of fixes and new features somewhere (is the NEWS.md fully up to date)? I honestly can't really review this because I have not touched {echarts4r} in a very long time despite being the author. I'll let @munoztd0 review this. Do we have any breaking change in here? Certainly looking forward to merging this, thanks again to the two of you for all your hard work on this! |
Yeah thanks a lot for the updates really appreciate! I will have a look at it if not this week the next one promise, In the meanwhile make sure to add your names as contributors in the DESCRIPTION |
|
Yes, NEWS.md is up to date - so is v6.rmd that also summarizes the changes. We don't anticipate any breaking changes. @patrekieta agree? There were a few proxy chart functions not working, but now they are working. Our names are in DESC. |
|
I have not encountered any breaking changes and there was no need to deprecate anything. We mostly added new features in addition to some bug fixes. The highlight new features include: new themes, new chart types, a new annotations system, and the new matrix coordinate system. At this point, all files should be up to date including news.md and the DESC. It's possible we are missing something as this is the first time that I and @jacciz are working on a CRAN release. Vignettes should also be up to date. We are looking forward to next steps and don't hesitate to reach out with questions or concerns. I'm honestly not sure what the process looks like from here. |
|
Was that not meant to be merged into |
Yes but I will do a few CRAN stuff or the CRAN branch (which is just master), tag it, do the CRAN submission and then merge it into master after all that to keep it clean |
* Initial bump to echarts v6 (#675) * First bump to echarts v6.0.0. Updated echarts-en.min.js to echarts.min.js. Updated folder name at echarts4r/inst/htmlwidgets/lib/echarts-6.0.0 to represent the new echarts version. Both added new languages/themes and updated old ones in echarts4r/inst/htmlwidgets/lib/echarts-6.0.0/themes and echarts4r/inst/htmlwidgets/lib/echarts-6.0.0/i18n * update languages * Updated e_theme to allow for new v6 themes * Starting implementation of chord charts * Added new function to generate chord charts. Added helper functions to generate new axis break zigzags. * Created helper function for official implementation of jitter into scatter plots. Fixed error in e_scatter_() that resulted in a failed dplyr::select() if your data column names are x or y. * Updated e_scatter() manual to indicate deprecation of old jitter functionality. * update file paths and docs * Added segmented doughnut chart as plugin * started a violin chart * violin * added violin args to function * added rd files * Updated JS file for segmented doughnuts for easier implementation in the future * more docs * test * updated comment * Added e_violin2 as a possible alternative function to e_violin. * Early implementation for adding the matrix coordinate system to charts. * replaced e_violin with the improved e_violin2 * added e_barRange * added new news * change arg names to match e_band_ * fixed issue where only the first trace the legend was being added * added e_contour, fixed legend issue with e_violin * lineRange almost finished * new charts match existing formats and support timeline * replaced all "htmlwidgets/lib/echarts-4.8.0" with "htmlwidgets/lib/echarts-6.0.0" * updated testthat to v3, added dplyr::all_of to remove warnings, passes CMD check w/ no warnings/errors. Started e_stage() * added unit tests * Moved matrix functions into their own R script. Added e_matrix_pie to build pie charts in matrix system. * added unit tests to check for missing inputs * adjust matrix functions * Adjusted matrix functions to allow extra arguments * Adjusted and renamed documentation for matrix. Added scatter and heatmap plots for matrix coordinate system. * adding unit tests to check for "stop" messages, a few small bugs and more coverage * adjusted units tests, found a few bugs per TODO notes to fix * Rebuilt an earlier commit and updated documentation for matrix functions * added testServer for some proxy functions, e_stage still not complete * added raw matrix (rows/cols) implementation. Added early implementation to add charts to your raw matrix. Updated documentation * reformatted roxy tags to pass check * Fixed documentation and corrected multiple bugs in e_matrix_addChart * Updated documentation. Added functionality for geoFacet style charting. Added geoFacet as an import which allows the user to get geoFacet grids for use in charts. * Fixed issue in echarts4rBox() which caused the function to fail if given column vectors as x,y rather than column name as a string. * Fixed bug in e_geoFacet() * e_stage is finished * fixed bug where name was NULL when y_index > 0 * adding more unit tests, for plugins, color, loading * Updated DESC to show new contributors * changed = to ->, 1:length() to seq_along, suggestions from goodpractice * a lot more unit testing for chart types and plugins, added flights as package data * more unit tests for proxy, added stop() to check if e$x$mapping$x is NULL and to tell user to provide x in echarts4rProxy. Added flights to data * updated DESC, passes check with only 1 note * fixed TODOs, started unit test for x_index and y_index * fixed legend in linerange, e_gauge, started matrix unit testing * adding unit tests for matrix functions * added unit tests for boxes, matrix and actions * fixed error for issue 494 when using e_add_nested() with e_bar() and polar coord system * fixed error for issue 494 when using e_add_nested() with e_bar() and polar coord system * more unit tests, updated NEWS * added unit tests for timeline * more unit tests for timeline and other smaller functions * more unit tests for grid, map, more * updated mapbox to newest version, file is 1mb larger * bug fixes * more unit tests, coverage is 94% * Adjusted how e_geoFacet() finds geofacet grids. Fixed examples for e_geoFacet() and e_title_matrix() * added unit tests for proxies * Deleted 48 i18n files Deleted 35 theme files To get below 5MB, new size : 4.83 MB * Added 195 and removed 0 words in \echarts4r\inst\WORDLIST * Updates TODOs for matrix. Blocked support for timelines in matrix functions. * added e_annotations along with a shiny binding * removed geofacet from imports * updated anno docs * Changed how e_geofacet interacts with geofacet package. Added helper functions to check for geofacet and install if needed. Updated e_geofacet docs. * added geofactor/cli to suggests and in the example so it passes cmd check * tested annotations in shiny and made change so SVG line renders properly and when window size changes * fixed issue with formatter not applying to x axis so i removed it like other formatters, pie formatter also works * added leaflet js and css and ITS WORKING * started v6 vignette, updated news * added data for leaflet, units tests for leaflet and annotations * cleaned up annos * Update testthat version requirement * Updated DESC. Updated _pkgdown.yml with new functions. Fixed typo in timeline vignette * Added e_insert_data to allow inserting data directly into series. Used to solve issue #592. Added additional functions to pkgdown.yml * changing annos so they are fully rendered by SVG not echart graphics * annos can be removed simply by the legend * put annotations in a js file, started vignette for annotations * more refined annotation examples and unit tests. Annotation legend works properly. * Updated old themes. Added in missing themes. Updated pkgdown for new pages. Started work on a Matrix vignette. * in annotations, removed group, edited js file so functions are more separated * added matrix example for annotations, edited roxy * added an example of e_group_g() with relative top/bottom using '%' * Fixed bug in e_matrix_addChart when using pie charts. Completed matrix vignette. * Updated matrix vignette. Fixed bug in e_matrix that broke rmarkdown and quarto rendering. * Updated e_matrix_addChart to allow for visual maps. Finished v6 vignette. Added chord chart type to chart_types vignette. * finalized updates to news.md * minor edits to comments / text * bug fix with e_heatmap_matrix --------- Co-authored-by: Jacci Ziebert <jacciziebert@gmail.com> Co-authored-by: munoztd0 <david.munoztord@mailbox.org> * close #680 * geodata fix * docs rerrun check --------- Co-authored-by: Patrick Rekieta <Patrick.Rekieta@gmail.com> Co-authored-by: Jacci Ziebert <jacciziebert@gmail.com>
Here is my attempt at starting the process to bump to v6. This is my first pull request so let me know if anything needs to get changed. Here is a list of what has been accomplished so far:
I need to step away for a couple days but future plans include:
Let me know if there are any issues or if there is anything else that should be included in my list to accomplish.