changed code fix part to use "fix all" and only fixes P1 list rather …#2
Merged
JieCarolHu merged 2 commits intoJieCarolHu:formatDoc_preview1from May 2, 2018
Merged
Conversation
…than fix everything in the document. also not apply changes to buffer until everything is done rather than doing it per fix.
Author
|
@JieCarolHu can you take a look? this should make format document a bit faster. |
Author
|
@JieCarolHu I don't have permission so can't merge. |
heejaechang
commented
May 2, 2018
|
|
||
| var dummy = new ProgressTracker(); | ||
| foreach (var diagnosticId in new string[] { | ||
| IDEDiagnosticIds.AddBracesDiagnosticId, |
Author
There was a problem hiding this comment.
@kuhlenh I think I added all P1 you said except expression body converting. do you want that one as well for demo? more diagnostics means more work means get slower. so if we don't need it, leaving out will be better :)
JieCarolHu
pushed a commit
that referenced
this pull request
May 4, 2018
…struction Fix issue where a write wasn't detected in make-readonly #2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…than fix everything in the document. also not apply changes to buffer until everything is done rather than doing it per fix.