Fix DomElement::attributes type#1741
Merged
isfedorov merged 1 commit intoJetBrains:masterfrom May 14, 2025
Merged
Conversation
Contributor
Author
|
Error seems unrelated |
Jean85
added a commit
to Jean85/phpstorm-stubs
that referenced
this pull request
May 27, 2025
Jean85
added a commit
to Jean85/phpstorm-stubs
that referenced
this pull request
May 27, 2025
stof
reviewed
Jun 9, 2025
|
|
||
| /** | ||
| * @var DOMNamedNodeMap<DOMAttr> | ||
| * @var DOMNamedNodeMap<DOMAttr>|null |
Contributor
There was a problem hiding this comment.
The type also need to be updated in the LanguageLevelTypeAware attribute defining the native type per PHP version.
Contributor
Author
isfedorov
pushed a commit
that referenced
this pull request
Jun 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @isfedorov
The description say
and the signature should be the same than DomNode.