Skip to content

[web] limit preventDefault-ing of processed pointer events only for touchscreens#2973

Merged
Shagen Ogandzhanian (Schahen) merged 1 commit into
jb-mainfrom
sh/web-dnd-minimal-regression-fix
Apr 13, 2026
Merged

[web] limit preventDefault-ing of processed pointer events only for touchscreens#2973
Shagen Ogandzhanian (Schahen) merged 1 commit into
jb-mainfrom
sh/web-dnd-minimal-regression-fix

Conversation

@Schahen

Copy link
Copy Markdown

We fight the undesired toggling of Virtual Keyboard view (caused by input losing it's focus) by prevent defaulting the pointer event if we know that compose processed it. Unfortunately this cancels out the drag-n-drop behaviour for nodes with both clickable and dragAndDropSource modifiers.

The smallest, safest and quickest fix is just to revert to limiting this behaviour to touchscreens. This means that the DnD logic still won't work on mobile devices but this should be addressed separately

Testing

manual + ./gradlew testWeb

Release Notes

Fixes - Web

CMP-10035 dragAndDropSource combined with clickable doesn't allow to start drag

@Schahen Shagen Ogandzhanian (Schahen) merged commit ff55f9c into jb-main Apr 13, 2026
17 checks passed
@Schahen Shagen Ogandzhanian (Schahen) deleted the sh/web-dnd-minimal-regression-fix branch April 13, 2026 12:45
Shagen Ogandzhanian (Schahen) added a commit that referenced this pull request Apr 13, 2026
…ouchscreens (#2973)

We fight the undesired toggling of Virtual Keyboard view (caused by
input losing it's focus) by prevent defaulting the pointer event if we
know that compose processed it. Unfortunately this cancels out the
drag-n-drop behaviour for nodes with both `clickable` and
`dragAndDropSource` modifiers.

The smallest, safest and quickest fix is just to revert to limiting this
behaviour to touchscreens. This means that the DnD logic still won't
work on mobile devices but this should be addressed separately

## Testing
manual + `./gradlew testWeb`

## Release Notes
### Fixes - Web

[CMP-10035](https://youtrack.jetbrains.com/issue/CMP-10035)
dragAndDropSource combined with clickable doesn't allow to start drag
Vlad Konstantinov (Kpotko) added a commit that referenced this pull request Apr 13, 2026
…ouchscreens (#2974)

This is cherry-pick of ff55f9c (see
#2973)

We fight the undesired toggling of Virtual Keyboard view (caused by
input losing it's focus) by prevent defaulting the pointer event if we
know that compose processed it. Unfortunately this cancels out the
drag-n-drop behaviour for nodes with both `clickable` and
`dragAndDropSource` modifiers.

The smallest, safest and quickest fix is just to revert to limiting this
behaviour to touchscreens. This means that the DnD logic still won't
work on mobile devices but this should be addressed separately

## Testing
manual + `./gradlew testWeb`

## Release Notes
### Fixes - Web

[CMP-10035](https://youtrack.jetbrains.com/issue/CMP-10035)
dragAndDropSource combined with clickable doesn't allow to start drag
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants