Skip to content

Correctly initialize focusManager and inputModeManager in DefaultOpenContextMenu#2945

Merged
Alexander Maryanovsky (m-sasha) merged 1 commit into
jb-mainfrom
m-sasha/fix-key-events-in-DefaultOpenContextMenu
Apr 7, 2026
Merged

Correctly initialize focusManager and inputModeManager in DefaultOpenContextMenu#2945
Alexander Maryanovsky (m-sasha) merged 1 commit into
jb-mainfrom
m-sasha/fix-key-events-in-DefaultOpenContextMenu

Conversation

@m-sasha

Copy link
Copy Markdown

Correctly initialize focusManager and inputModeManager in DefaultOpenContextMenu

Fixes NPE in DefaultOpenContextMenu when key event arrives before inputModeManager is initialized

Testing

Tested manually and added a new unit test

This should be tested by QA

Release Notes

Fixes - Multiple Platforms

  • Fixed crash when pressing up/down keys in an open context menu.

@m-sasha Alexander Maryanovsky (m-sasha) force-pushed the m-sasha/fix-key-events-in-DefaultOpenContextMenu branch 2 times, most recently from 043dc2d to 816fc1a Compare April 7, 2026 09:09
@m-sasha Alexander Maryanovsky (m-sasha) force-pushed the m-sasha/fix-key-events-in-DefaultOpenContextMenu branch from 816fc1a to b9d4879 Compare April 7, 2026 10:32
@m-sasha Alexander Maryanovsky (m-sasha) merged commit eec6604 into jb-main Apr 7, 2026
17 checks passed
@m-sasha Alexander Maryanovsky (m-sasha) deleted the m-sasha/fix-key-events-in-DefaultOpenContextMenu branch April 7, 2026 19:09
Vlad Konstantinov (Kpotko) added a commit that referenced this pull request Apr 13, 2026
…ContextMenu (#2976)

Correctly initialize focusManager and inputModeManager in
DefaultOpenContextMenu

This is a cherry-pick of
#2945

## Testing
N/A

## Release Notes
### Fixes - Multiple Platforms
- Fixed crash when pressing up/down keys in an open context menu.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants