Fix ModalBottomSheetDialog content insets#2849
Merged
Vendula Švastalová (svastven) merged 4 commits intoMar 31, 2026
Merged
Conversation
| dismissOnClickOutside = properties.shouldDismissOnClickOutside, | ||
| usePlatformDefaultWidth = false, | ||
| usePlatformInsets = false, | ||
| usePlatformInsets = true, |
Collaborator
There was a problem hiding this comment.
It doesn't look correct to me. The dialog itself should remain "full screen". Insets should work correctly with usePlatformInsets = false.
It seems that the fix should be on lower levels without touching material3 module
Collaborator
There was a problem hiding this comment.
Confirmed that it breaks basic usage even in mpp
jb-main |
#2849 |
|---|---|
 |
 |
 |
 |
Ivan Matkov (MatkovIvan)
requested changes
Mar 11, 2026
| dismissOnClickOutside = properties.shouldDismissOnClickOutside, | ||
| usePlatformDefaultWidth = false, | ||
| usePlatformInsets = false, | ||
| usePlatformInsets = true, |
Collaborator
There was a problem hiding this comment.
Confirmed that it breaks basic usage even in mpp
jb-main |
#2849 |
|---|---|
|
|
|
|
Author
|
Ivan Matkov (@MatkovIvan) thanks for the example. That does not look correct. We could have some test when this behavior is not met. I will add it and investigate deeper. |
06b9a94 to
af6b6a9
Compare
af6b6a9 to
49d0020
Compare
Vladimir Mazunin (mazunin-v-jb)
approved these changes
Mar 31, 2026
Andrei Salavei (ASalavei)
approved these changes
Mar 31, 2026
49d0020 to
ff40d32
Compare
Author
|
Checked various usages and current behavior should be consistent with 
I have also added an example screen as part of this PR to demonstrate 
|
f42a237 to
b409874
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix
ModalBottomSheetDialogcontent insets by not excluding IME insets from inner contentFixes https://youtrack.jetbrains.com/issue/CMP-9846
Testing
Add
ModalBottomSheetTesttest suiteI have also added an example screen as part of this PR to demonstrate
ModalBottomSheetwithIME.This should be tested by QA
Release Notes
Fixes - iOS
ModalBottomSheetDialogcontent inset calculation