Refactor resource accessors generator to minify output source files.#5298
Merged
Conversation
- Number of items per file was decreased to 100 - Common part of the path extracted to the private const - Added imports - Removed the private object with item's properties - The file structure was reorganized
This test verifies the generation of resource files and accessors for projects with a massive number of resources (25_000 icons + (25_000 * 80) strings).
3f580ec to
1223819
Compare
Igor Demin (igordmn)
approved these changes
Apr 29, 2025
Konstantin (terrakok)
added a commit
that referenced
this pull request
May 9, 2025
…5298) Refactor resource accessors generator to minify output source files. - Number of items per file was decreased to 100 - Common part of the path extracted to the private const - Added imports - Removed the private object with item's properties - The file structure was reorganized Fixes [CMP-7934](https://youtrack.jetbrains.com/issue/CMP-7934) Too large String0.commonMain.kt will break code insight feature in AS ## Testing Integration tests. This should be tested by QA ## Release Notes ### Fixes - Resources - Fix IDE highlighting/resoulution when a generated file with resource accessors is too big (cherry picked from commit 1b6e615)
Merged
Vlad Konstantinov (Kpotko)
pushed a commit
that referenced
this pull request
May 9, 2025
…5298) Refactor resource accessors generator to minify output source files. - Number of items per file was decreased to 100 - Common part of the path extracted to the private const - Added imports - Removed the private object with item's properties - The file structure was reorganized Fixes [CMP-7934](https://youtrack.jetbrains.com/issue/CMP-7934) Too large String0.commonMain.kt will break code insight feature in AS ## Testing Integration tests. This should be tested by QA ## Release Notes ### Fixes - Resources - Fix IDE highlighting/resoulution when a generated file with resource accessors is too big (cherry picked from commit 1b6e615)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor resource accessors generator to minify output source files.
Fixes CMP-7934 Too large String0.commonMain.kt will break code insight feature in AS
Testing
Integration tests.
This should be tested by QA
Release Notes
Fixes - Resources