Gradle Plugin DSL to change the generated Res class name#5296
Merged
Conversation
Collaborator
|
Requires 2 approvals, as this is new API in Gradle plugin |
Igor Demin (igordmn)
approved these changes
Apr 29, 2025
| abstract val packageName: Property<String> | ||
|
|
||
| @get:Input | ||
| abstract val resClassName: Property<String> |
Collaborator
There was a problem hiding this comment.
Should we name it just className? To be consistent with packageName and to avoid double wording in resources { res... =
Member
Author
There was a problem hiding this comment.
I don't think so, because it changes the Res class name only.
Member
Author
There was a problem hiding this comment.
for the consistency I'll rename it to nameOfResClass
Collaborator
|
Please, also fix the new failing check. |
Alexander Maryanovsky (m-sasha)
approved these changes
May 5, 2025
99d2ff0 to
ec241c1
Compare
Konstantin (terrakok)
added a commit
that referenced
this pull request
May 9, 2025
Gradle Plugin DSL to change the generated Res class name:
```kotlin
compose.resources {
nameOfResClass = "MyRes"
}
```
Fixes [CMP-7341](https://youtrack.jetbrains.com/issue/CMP-7341) Support
generating custom resource class name
## Testing
Integration tests.
## Release Notes
### Features - Resources
- Gradle Plugin DSL to change the generated Res class name
Co-authored-by: Omico <me@omico.icu>
(cherry picked from commit 3c531dd)
Merged
Vlad Konstantinov (Kpotko)
pushed a commit
that referenced
this pull request
May 9, 2025
Gradle Plugin DSL to change the generated Res class name:
```kotlin
compose.resources {
nameOfResClass = "MyRes"
}
```
Fixes [CMP-7341](https://youtrack.jetbrains.com/issue/CMP-7341) Support
generating custom resource class name
## Testing
Integration tests.
## Release Notes
### Features - Resources
- Gradle Plugin DSL to change the generated Res class name
Co-authored-by: Omico <me@omico.icu>
(cherry picked from commit 3c531dd)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Gradle Plugin DSL to change the generated Res class name:
compose.resources { nameOfResClass = "MyRes" }Fixes CMP-7341 Support generating custom resource class name
Testing
Integration tests.
Release Notes
Features - Resources
Resclass name