feat: EXPOSED-188 Support Propagation in SpringTransactionManager#1867
Merged
bog-walk merged 10 commits intoJetBrains:mainfrom Sep 25, 2023
Merged
Conversation
bog-walk
reviewed
Sep 24, 2023
...ng-transaction/src/test/kotlin/org/jetbrains/exposed/spring/ExposedTransactionManagerTest.kt
Show resolved
Hide resolved
bog-walk
requested changes
Sep 24, 2023
Member
bog-walk
left a comment
There was a problem hiding this comment.
@FullOfOrange Thanks for the great PR and the very thorough tests!
Just 2 minor technical changes requested.
...ng-transaction/src/test/kotlin/org/jetbrains/exposed/spring/ExposedTransactionManagerTest.kt
Outdated
Show resolved
Hide resolved
This was
linked to
issues
Sep 24, 2023
bog-walk
approved these changes
Sep 24, 2023
...ng-transaction/src/test/kotlin/org/jetbrains/exposed/spring/ExposedTransactionManagerTest.kt
Outdated
Show resolved
Hide resolved
...ng-transaction/src/test/kotlin/org/jetbrains/exposed/spring/ExposedTransactionManagerTest.kt
Outdated
Show resolved
Hide resolved
saral
pushed a commit
to saral/Exposed
that referenced
this pull request
Oct 3, 2023
…tBrains#1867) * feat: add nested transaction feature * test: add nested transaction test * test: Add requires new and never test * refactor: spring test refactoring * refactor: spring test * refactor: Refactoring spring transaction * test: support and mandatory * refactor: apply code review assert function * docs: add test comments * refactor: apply code review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implemented the Propagation policy in SpringTransactionManager.
In addition to REQUIRED, we now support SUPPORTS, MANDATORY, REQUIRES_NEW, NOT_SUPPORTED, NEVER, and NESTED.
The changes are as follows