Use ResizeObserver to auto-update menu position if available#5404
Merged
Methuselah96 merged 2 commits intomasterfrom Oct 20, 2022
Merged
Use ResizeObserver to auto-update menu position if available#5404Methuselah96 merged 2 commits intomasterfrom
Methuselah96 merged 2 commits intomasterfrom
Conversation
🦋 Changeset detectedLatest commit: 1299fe9 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 1299fe9:
|
Rall3n
approved these changes
Oct 20, 2022
Merged
Rall3n
pushed a commit
to Rall3n/react-select
that referenced
this pull request
Oct 21, 2022
…on#5404) * Use ResizeObserver to update menu position if available Fixes JedWatson#5403. I mistakenly thought in JedWatson#5381 that the resize event was placed on the control element, but's it really just on the scroll parents of the control element. This PR enables `ResizeObserver` if it's available. The referenced issue demonstrates a good use-case for it. * Create tricky-books-design.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5403.
I mistakenly thought in #5381 that the resize event was placed on the control element, but's it really just on the scroll parents of the control element.
This PR enables
ResizeObserverif it's available. The referenced issue demonstrates a good use-case for it.