Remove problematic test case#328
Merged
alexander-schranz merged 1 commit intoJan0707:masterfrom Mar 13, 2024
Merged
Conversation
bcf1005 to
81e1b4f
Compare
Contributor
Author
|
@alexander-schranz As per discussion in #285 I opted to use approach that includes minimal changes to make the build green. Let me know what do you think :) |
|
This replaces #327, correct? |
Collaborator
|
Fine for me currently, is there still a way we could test this? |
Contributor
Author
|
@alexander-schranz Test case described in the issue is one that is verifying this functionality and it should be included (sooner or later). Currently only limitation is different phpstan output which we could add and create CI matrix to test it as well. Moreover if support is dropped for older PHP versions output might be more consistent. |
Jean85
added a commit
to facile-it/paraunit
that referenced
this pull request
Mar 18, 2024
This is to include a couple of PRs pending release: * Jan0707/phpstan-prophecy#328 * phpspec/prophecy-phpunit#63
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts only part of #316
Following test case produces different phpstan analyisis output depending on used versions:
Creating Prophet inline seems like a valid use case that should be supported as well. In combination with PHPUnit 10.0.0. this produced internal phpstan error due to following lines. I added the test case thus this use case is visible and supported however output is different based on combination of versions thus it is hard to support this without having version specific baseline(s).
More developers are reaching for this use case as PHPUnit 10 deprecated non-static data providers (see sebastianbergmann/phpunit@9caafe2). Easy way out is to use
(new Prophet()).