Skip to content

Fix linux default open folder and terminal#9966

Merged
Siedlerchr merged 3 commits into
mainfrom
fixLinuxDefaultOpenFolderAndTerminal
Jun 4, 2023
Merged

Fix linux default open folder and terminal#9966
Siedlerchr merged 3 commits into
mainfrom
fixLinuxDefaultOpenFolderAndTerminal

Conversation

@Siedlerchr

@Siedlerchr Siedlerchr commented May 31, 2023 •
edited
Loading

Copy link
Copy Markdown
Member

Fixes #9607

Mandatory checks

  • Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
  • Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

Siedlerchr added 2 commits May 31, 2023 18:55
@Siedlerchr
Fix opening folder instead of file under linux
52868d0 
fixes #9607
add thunar + xfce check
@Siedlerchr
Merge remote-tracking branch 'upstream/main' into fixLinuxDefaultOpen…
453dd56 
…FolderAndTerminal

* upstream/main:
  Fixed deleting Automatic Keyword Group in the UI (#9955)

# Conflicts:
#	CHANGELOG.md
github-actions[bot]
github-actions Bot reviewed May 31, 2023
View reviewed changes
Comment thread src/main/java/org/jabref/gui/desktop/os/Linux.java Outdated
@calixtus

calixtus commented Jun 1, 2023

Copy link
Copy Markdown
Member

Codewise looks good

@Siedlerchr

Siedlerchr commented Jun 1, 2023

Copy link
Copy Markdown
Member Author

Just need someone to test this on linux

@ThiloteE

ThiloteE commented Jun 1, 2023 •
edited
Loading

Copy link
Copy Markdown
Member

works with linux mint 20.3 Cinnamon (Nemo file manager) kernel 5.4, but it was working without this PR as well...

@JabRef JabRef deleted a comment from github-actions Bot Jun 3, 2023
@Siedlerchr

Siedlerchr commented Jun 4, 2023

Copy link
Copy Markdown
Member Author

I am mergin this in the hope that the users will complain when it doesn't work

@Siedlerchr Siedlerchr merged commit 76c35f0 into main Jun 4, 2023
@Siedlerchr Siedlerchr deleted the fixLinuxDefaultOpenFolderAndTerminal branch June 4, 2023 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@calixtus calixtus calixtus approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

"open folder" opens file instead of folder

3 participants

@Siedlerchr @calixtus @ThiloteE