Skip to content

Fixed deleting Automatic Keyword Group in the UI#9955

Merged
Siedlerchr merged 9 commits into
JabRef:mainfrom
brunaoo:fix-for-issue-9778
May 30, 2023
Merged

Fixed deleting Automatic Keyword Group in the UI#9955
Siedlerchr merged 9 commits into
JabRef:mainfrom
brunaoo:fix-for-issue-9778

Conversation

@brunaoo

@brunaoo brunaoo commented May 29, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor

fixes #9778

We fixed an issue preventing the deletion of an Automatic Keyword Group, when the group had no name.

Captura de tela de 2023-05-11 20-29-14

### Compulsory checks
- [X] Change in `CHANGELOG.md` described in a way that is understandable for the average user (if applicable)
- [ ] Tests created for changes (if applicable)
- [X] Manually tested changed features in running JabRef (always required)
- [ X] Screenshots added in PR description (for UI changes)
- [X] [Checked developer's documentation](https://devdocs.jabref.org/): Is the information available and up to date? If not, I outlined it in this pull request.
- [ ] [Checked documentation](https://docs.jabref.org/): Is the information available and up to date? If not, I created an issue at <https://github.com/JabRef/user-documentation/issues> or, even better, I submitted a pull request to the documentation repository.

@brunaoo brunaoo closed this May 29, 2023
@brunaoo brunaoo force-pushed the fix-for-issue-9778 branch from ef03d68 to e021686 Compare May 29, 2023 11:05
@brunaoo brunaoo reopened this May 29, 2023
@brunaoo brunaoo changed the title Fix for issue 9778 Fixed deleting Automatic Keyword Group in the UI May 29, 2023
calixtus
calixtus reviewed May 29, 2023
View reviewed changes
Comment thread src/main/java/org/jabref/gui/groups/GroupTreeViewModel.java Outdated
calixtus
calixtus previously approved these changes May 30, 2023
View reviewed changes

@calixtus calixtus left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks for the addition. Looks good to me!

Siedlerchr
Siedlerchr reviewed May 30, 2023
View reviewed changes
Comment thread CHANGELOG.md Outdated
Siedlerchr
Siedlerchr previously approved these changes May 30, 2023
View reviewed changes
@Siedlerchr Siedlerchr merged commit 424ff1c into JabRef:main May 30, 2023
Siedlerchr added a commit that referenced this pull request May 31, 2023
@Siedlerchr
Merge remote-tracking branch 'upstream/main' into fixLinuxDefaultOpen…
453dd56 
…FolderAndTerminal

* upstream/main:
  Fixed deleting Automatic Keyword Group in the UI (#9955)

# Conflicts:
#	CHANGELOG.md
@koppor koppor mentioned this pull request Jun 6, 2023
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Siedlerchr Siedlerchr Siedlerchr approved these changes

@calixtus calixtus calixtus left review comments

Assignees

No one assigned

Labels

component: groups

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Impossible to delete an Automatic Keyword Group in the UI

4 participants

@brunaoo @Siedlerchr @calixtus @ThiloteE