Preferences ui cleanup B#9866
Conversation
…and autosave to LibraryTab
|
Open last libraries on startup should be in libraries tab and not in appearance tab |
|
Imho not, because you do not configure a library option, but the behaviour of the GUI. |
|
Difficult UX discussion. I lean towards the libraries tab, because this is more empty than the other. |
|
If I would look for an option about the startup of the GUI and how the GUI should look, I would not look at first in the libraries tab. The contents of a preference tab configure the inner behaviour of the feature. To show the last opened library on startup has nothing to do with how libraries should behave. |
|
But semantically it is related to the library. Logical grouping of functions. |
|
We deffo schould ask our users! |
|
Two scenarios (two times two tabs side by side; picture) then let vote? 😅 |
|
Proposed change with this PR: Mockup with the "open last files on startup" in the libraries tab. We probably should then also include the setting to open the last opened shared databases here too (#9843) JabRefFrame and JabRefGUI will have to be changed to use the LibraryPreferences. Imho, this is nonsense. |
|
A quick survey on different applications: How IntelliJ handles it: VSCode sorts a compareable option in "Workbench" Firefox in General: MSOffice / Notepad++ / Gimp / does not provide that feature (at least i did not find it) @Siedlerchr can you please check, how eclipse handles this and post a screenshot? |
# Conflicts: # src/main/java/org/jabref/cli/ArgumentProcessor.java # src/main/java/org/jabref/gui/exporter/SaveDatabaseAction.java # src/main/java/org/jabref/logic/autosaveandbackup/BackupManager.java # src/main/java/org/jabref/logic/crawler/StudyRepository.java
…ditorTab, reordered tabs
| import org.jabref.model.strings.StringUtil; | ||
|
|
||
| /** | ||
| Preferences for the linked files |
There was a problem hiding this comment.
🚫 [reviewdog] <com.puppycrawl.tools.checkstyle.checks.javadoc.JavadocMissingLeadingAsteriskCheck> reported by reviewdog 🐶
Javadoc line should start with leading asterisk.
|
Your code currently does not meet JabRef's code guidelines. The tool reviewdog already placed comments on GitHub to indicate the places. See the tab "Files" in you PR. Please carefully follow the setup guide for the codestyle. Afterwards, please run checkstyle locally and fix the issues. More information on code quality in JabRef is available at https://devdocs.jabref.org/getting-into-the-code/development-strategy.html. |
Follow up to #9839
moved memory stick mode toggle to toolbar
removed general tab and general preferences
polished KeyBindingsTab
added missing symbols in CustomImporterTab / CustomExporterTab
added small border to combobox popups (before / after)
renamed AppearanceTab to WorkspaceTab and reworked it, AppearancePreferences to WorkspacePreferences
merged LibraryTab with WorkspaceTab
moved Autocompletion into its own tab und moved Custom entry editor tabs settings into EntryEditorTab
reordered preferences tabs
.