Skip to content

Preferences ui cleanup#9839

Merged
Siedlerchr merged 12 commits into
mainfrom
websearch_prefs
May 5, 2023
Merged

Preferences ui cleanup#9839
Siedlerchr merged 12 commits into
mainfrom
websearch_prefs

Conversation

@calixtus

@calixtus calixtus commented May 4, 2023

Copy link
Copy Markdown
Member
  • introduced web search tab
    grafik
  • renamed Import and Export tab to Export tab
    grafik
  • moved remaining content to entry tab, refined ui (reduced vertical space, added indentation)
    grafik
  • removed files tab
  • removed unused code (TagBar / Tag, DiffHighlightingTextPane)

.

### Compulsory checks
- [ ] Change in `CHANGELOG.md` described in a way that is understandable for the average user (if applicable)
- [ ] Tests created for changes (if applicable)
- [x] Manually tested changed features in running JabRef (always required)
- [x] Screenshots added in PR description (for UI changes)
- [ ] [Checked developer's documentation](https://devdocs.jabref.org/): Is the information available and up to date? If not, I outlined it in this pull request.
- [ ] [Checked documentation](https://docs.jabref.org/): Is the information available and up to date? If not, I created an issue at <https://github.com/JabRef/user-documentation/issues> or, even better, I submitted a pull request to the documentation repository.

@calixtus calixtus changed the title Introducing Web search tab Preferences ui cleanup May 4, 2023
@koppor

koppor commented May 4, 2023

Copy link
Copy Markdown
Member

Reorganization also relates to #9836.

@koppor

koppor commented May 4, 2023

Copy link
Copy Markdown
Member

We have "Always reformat BIB file on save and export". Should we a) keep this setting both in "Library"/"File"/"General" and in "Export" or should we b) split it into "Always reformat BIB file on save" and "Always reformat BIB file on export". I lean to the former. But then, the UI setting appears in two different tabs. Hopefully, they are synchronized!

@calixtus

calixtus commented May 4, 2023

Copy link
Copy Markdown
Member Author

I removed the files tab. So the autosave setting should not appear twice.

@Siedlerchr

Siedlerchr commented May 4, 2023

Copy link
Copy Markdown
Member

Oh no please not, my other PR is using the files tab

@calixtus

calixtus commented May 4, 2023

Copy link
Copy Markdown
Member Author

Should not be a big deal to fix the merge conflicts

@calixtus calixtus added dev: code-quality Issues related to code or architecture decisions component: preferences status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers labels May 4, 2023
@koppor

koppor commented May 4, 2023

Copy link
Copy Markdown
Member

I removed the files tab. So the autosave setting should not appear twice.

It is about reformatting, not saving. 😅

Saving is only concerning the library, but reformatting both the library (.bib) and export (as .bib).

@calixtus

calixtus commented May 5, 2023

Copy link
Copy Markdown
Member Author

I will make a follow up PR introducing a library tab. But I think it will be too much for this PR as I already changed 42 files with this one.

@calixtus

calixtus commented May 5, 2023

Copy link
Copy Markdown
Member Author

Thx for #

@Siedlerchr Siedlerchr merged commit e95fb75 into main May 5, 2023
@Siedlerchr Siedlerchr deleted the websearch_prefs branch May 5, 2023 17:32
@calixtus calixtus mentioned this pull request May 9, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Siedlerchr Siedlerchr Siedlerchr approved these changes

@koppor koppor koppor approved these changes

Assignees

No one assigned

Labels

component: preferences dev: code-quality Issues related to code or architecture decisions status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@calixtus @koppor @Siedlerchr