Skip to content

Reorganized "General tab" (preamble still here) and "String constants…#9836

Merged
Siedlerchr merged 8 commits into
JabRef:mainfrom
deybis17:reorganization_library_properties
May 6, 2023
Merged

Reorganized "General tab" (preamble still here) and "String constants…#9836
Siedlerchr merged 8 commits into
JabRef:mainfrom
deybis17:reorganization_library_properties

Conversation

@deybis17

@deybis17 deybis17 commented May 3, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor

…" placed after "Citation key patterns"

Fixes #9818

  • Reorganization of the Order of Tabs:
    Before: General, Saving, String constants, Citation key patterns and Content selectors
    Now: General, Saving, Citation key patterns, String constants and Content selectors

  • Reorganization of the contents in General Tab:
    Before: General, Override default file directories and Preamble
    Now: Override default file directories, General and Preamble

  • It still missing to separate Preamble seccion in General tab and locate it in its own tab (Preamble Tab)

image

### Compulsory checks
- [x] Change in `CHANGELOG.md` described in a way that is understandable for the average user (if applicable)
- [ ] Tests created for changes (if applicable)
- [x] Manually tested changed features in running JabRef (always required)
- [x] Screenshots added in PR description (for UI changes)
- [ ] [Checked developer's documentation](https://devdocs.jabref.org/): Is the information available and up to date? If not, I outlined it in this pull request.
- [ ] [Checked documentation](https://docs.jabref.org/): Is the information available and up to date? If not, I created an issue at <https://github.com/JabRef/user-documentation/issues> or, even better, I submitted a pull request to the documentation repository.

@Siedlerchr

Siedlerchr commented May 3, 2023

Copy link
Copy Markdown
Member

Please also add a changelog entry

@koppor

koppor commented May 4, 2023 •
edited by Siedlerchr
Loading

Copy link
Copy Markdown
Member

@deybis-villegas Thank you for working on this.

One more thing. Can you rename the 2nd general heading to "Miscellaneous". You will also need to add this string to JabRef_en.properties. see https://devdocs.jabref.org/code-howtos/localization.html

image

@deybis17 deybis17 marked this pull request as ready for review May 4, 2023 16:37
@koppor

koppor commented May 4, 2023

Copy link
Copy Markdown
Member

Can't do quick comment, because new screenshot is there. - I merged main so that this branch has no conflicts.

@deybis17

deybis17 commented May 4, 2023

Copy link
Copy Markdown
Contributor Author

General and preamble tab look like this now

image
image

Can't do quick comment, because new screenshot is there. - I merged main so that this branch has no conflicts.

@koppor koppor mentioned this pull request May 4, 2023
Merged
@koppor

koppor commented May 4, 2023

Copy link
Copy Markdown
Member

I am so sorry that I did not describe the picture content of the issue description as text.

May I mark the demand of the issue with an arrow and a yellow box?

image

As text: Swap "library mode" and "library encoding".

@deybis17

deybis17 commented May 4, 2023

Copy link
Copy Markdown
Contributor Author

I am so sorry that I did not describe the picture content of the issue description as text.

May I mark the demand of the issue with an arrow and a yellow box?

image

As text: Swap "library mode" and "library encoding".

Now it looks like this:

image

@calixtus

calixtus commented May 4, 2023

Copy link
Copy Markdown
Member

I took the liberty to shorten the changelog message a little bit. I hope you don't mind.

@Siedlerchr Siedlerchr merged commit 90be45a into JabRef:main May 6, 2023
@Siedlerchr

Siedlerchr commented May 6, 2023

Copy link
Copy Markdown
Member

Thanks a lot for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Siedlerchr Siedlerchr Siedlerchr approved these changes

Assignees

No one assigned

Labels

component: preferences

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Rearrange content of Library Properties Dialog

5 participants

@deybis17 @Siedlerchr @koppor @calixtus @ThiloteE