Added INSPIRE HEP Fetcher to "Update with bibliographic information from the web"#9602
Merged
Conversation
Added INSPIREFetcher to the set of GetEntryBasedFetchers.
Updated INSPIRE HEP Fetcher to implement the EntryBasedFetcher Interface.
Siedlerchr
requested changes
Feb 7, 2023
Siedlerchr
left a comment
Member
There was a problem hiding this comment.
Thanks for your contribution. Goes already in the right direction, but something seems to be off with your formatting style. Please import JabRef's code style
https://github.com/JabRef/jabref/tree/main/config#intellij-idea-code-style-configuration
And also please add a test case!
| String url = "https://inspirehep.net/api/doi" + doi; | ||
|
|
||
| try { | ||
| URL obj = new URL(url); |
Member
There was a problem hiding this comment.
You can use our UrlDownload class for this
URLDownload download = getUrlDownload(doiURL);
download.addHeader("Accept", MediaTypes.APPLICATION_BIBTEX);
This also handles errors
Contributor
Author
There was a problem hiding this comment.
@Siedlerchr I have fixed some logical bugs and corrected code style.
Now InspireHEP is working as desired as one of the resources to fetch bibliographic data from when given a valid doi.
Fixed some logical bugs in performSearch Function and also corrected the code style.
Siedlerchr
requested changes
Feb 14, 2023
* upstream/main: Show error only if user selected to store files in main directory Bump pascalgn/automerge-action from 0.15.5 to 0.15.6 Update Gradle Wrapper from 7.6 to 8.0.1. add missing newlines at the end import strings and add them to the new bibdatabase Add test Resolve strings in MsOffice export Checkstyle Update CHANGELOG.md Refine error message and remove obsolete string Squashed 'buildres/csl/csl-styles/' changes from b111f31efe..9926b48cf3 Fix storing multiline properties for custom fields in custom entry types Remove myself from MAINTAINERS (#9617) Fixed various fetcher tests (#9618)
calixtus
approved these changes
Feb 25, 2023
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #9351
Added INSPIREFetcher to the set of GetEntryBasedFetchers and also updated INSPIREFetcher to implement EntryBaseFetcher Interface.
This adds the Inspire button where one can fetch the data for existing entries.
TEST CASE:
Here for example is the doi for testing Inspire Fetcher: 10.1103/PhysRevLett.126.101101
Now we can fetch bibliographic data from InspireHEP for entries, which may had been imported from elsewhere or are missing an citation key.
CHANGELOG.mddescribed in a way that is understandable for the average user (if applicable)