Observable Preferences T (NameDisplayPreferences, MainTablePreferences, ColumnPreferences)#9535
Conversation
…references in new prefs pattern
Member
|
Seems to work fine. |
Siedlerchr
approved these changes
Jan 8, 2023
Member
Member
Member
Author
|
Is the maintable fine? Since this pr is reducing code duplication with the search dialog and the main table, this is probably a bug in the search dialog and hopefully not caused by my changes 😅 . So I agree, a follow up issue (maybe "good first") with bugs in the global search dialog should be filed and adressed |
Member
|
As far as I remember the columns in the search are just based on the main table but are stored separate. So they should be independent |
Member
Author
|
So as both reviewers approved or voted to merge, im merging. |
Siedlerchr
added a commit
that referenced
this pull request
Jan 16, 2023
…ialog * upstream/main: Bump xmlunit-core from 2.9.0 to 2.9.1 Bump mockito-core from 4.11.0 to 5.0.0 Bump xmlunit-matchers from 2.9.0 to 2.9.1 Bump junit-platform-launcher from 1.9.1 to 1.9.2 Squashed 'buildres/csl/csl-styles/' changes from 43566f2..50eea55b2c New translations JabRef_en.properties (Portuguese, Brazilian) (#9559) Changed the color of light-color-text and highlighted text in … (#9546) New translations JabRef_en.properties (Portuguese, Brazilian) (#9557) chore: improve debug output in powershell starter script (#9550) Show development information (#9555) Observable Preferences T (NameDisplayPreferences, MainTablePreferences, ColumnPreferences) (#9535)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Follow up to #9493
CHANGELOG.mddescribed in a way that is understandable for the average user (if applicable)