Skip to content

Observable Preferences P (OpenOffice)#9422

Merged
koppor merged 1 commit into
mainfrom
prefs_p
Dec 5, 2022
Merged

Observable Preferences P (OpenOffice)#9422
koppor merged 1 commit into
mainfrom
prefs_p

Conversation

@calixtus

@calixtus calixtus commented Dec 3, 2022

Copy link
Copy Markdown
Member

Follow up to #9173

  • Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
  • Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

@Siedlerchr

Copy link
Copy Markdown
Member

This reminds to check out if we still need all those different path prefs. I see that you already deleted some...

@calixtus

calixtus commented Dec 4, 2022

Copy link
Copy Markdown
Member Author

Only as a drive by, as it there was no use for the constants anymore and refactoring to the new prefs pattern would have been a waste of time. But feel free to update and append to this branch

@ThiloteE ThiloteE added component: libre-office dev: code-quality Issues related to code or architecture decisions component: preferences labels Dec 4, 2022

@Siedlerchr Siedlerchr left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked the constants again and seems fine to remove them

@koppor koppor merged commit bfd3446 into main Dec 5, 2022
@koppor koppor deleted the prefs_p branch December 5, 2022 19:18
@calixtus calixtus changed the title Observable Preferences (OpenOffice) Observable Preferences P (OpenOffice) Dec 11, 2022
Siedlerchr added a commit to MaryJml/jabref that referenced this pull request Dec 13, 2022
* upstream/main: (37 commits)
  Update database context in state manager after loading (JabRef#9450)
  Bump classgraph from 4.8.151 to 4.8.152 (JabRef#9448)
  Bump appleboy/ssh-action from 0.1.5 to 0.1.6 (JabRef#9443)
  Bump Pendect/action-rsyncer from 1.1.0 to 2.0.0 (JabRef#9444)
  Bump jackson-dataformat-yaml from 2.14.0 to 2.14.1 (JabRef#9445)
  Bump unirest-java from 3.14.0 to 3.14.1 (JabRef#9447)
  Bump postgresql from 42.5.0 to 42.5.1 (JabRef#9446)
  New Crowdin updates (JabRef#9435)
  Return absolute path in case an absolute one is given (JabRef#9433)
  New Crowdin updates (JabRef#9434)
  Fix for issue: right click menu 6601 (JabRef#9271)
  Fix modernizer and refactor protected terms (JabRef#9427)
  Observable Preferences (OpenOffice) (JabRef#9422)
  Allow users to review backup changes before restoring them or merge them selectively (JabRef#9311)
  Bump slf4j-api from 2.0.4 to 2.0.5 (JabRef#9428)
  Bump archunit-junit5-api from 1.0.0 to 1.0.1 (JabRef#9429)
  Bump jackson-datatype-jsr310 from 2.14.0 to 2.14.1 (JabRef#9430)
  Bump lucene-highlighter from 9.4.1 to 9.4.2 (JabRef#9431)
  Fix weird checkbox styling (JabRef#9425)
  New translations JabRef_en.properties (Italian) (JabRef#9424)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

component: libre-office component: preferences dev: code-quality Issues related to code or architecture decisions

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants