Fix missing CSS for some dialogs#9150
Merged
Merged
Conversation
…ading # Conflicts: # CHANGELOG.md
Siedlerchr
approved these changes
Sep 12, 2022
Siedlerchr
left a comment
Member
There was a problem hiding this comment.
Ah nice thanks for fixing!
Siedlerchr
added a commit
to LIM0000/jabref
that referenced
this pull request
Sep 12, 2022
* upstream/main: Fix missing CSS for some dialogs (JabRef#9150) Bump org.eclipse.jgit from 6.2.0.202206071550-r to 6.3.0.202209071007-r (JabRef#9152) Bump mockito-core from 4.7.0 to 4.8.0 (JabRef#9151) [GSOC22] - D - Test the Three Way Merge UI (JabRef#9069)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up to #8939
The dialogs are:
The reason behind the missing CSS is that these dialogs don't have the main window as an owner. The owner is responsible for passing the CSS stylesheets downstream, and if the owner is not set for the dialog, the CSS must be loaded explicitly. Fortunately, dialogs shown with
DialogServicehave their owner set automatically, allowing CSS to load successfully.Before
CHANGELOG.mddescribed in a way that is understandable for the average user (if applicable)