Clarify the duplicates resolver dialog actions#9140
Merged
Conversation
- Renamed the actions. - Changed their layout; some actions on the left and some on the right. - Commented out the help action for now.
- This enum was used by to decide what buttons to add to the duplicate resolver dialog in ImportEntriesDialog. However, both ImportHandler and ImportEntriesDialog have the same buttons. In addition, they share logic too. We should consider merging them at some point.
calixtus
approved these changes
Sep 6, 2022
calixtus
left a comment
Member
There was a problem hiding this comment.
LGTM except one comment left...
Siedlerchr
reviewed
Sep 12, 2022
Siedlerchr
reviewed
Sep 12, 2022
Siedlerchr
approved these changes
Sep 14, 2022
Siedlerchr
added a commit
to LIM0000/jabref
that referenced
this pull request
Sep 17, 2022
* upstream/main: Update to jfx 19 (JabRef#9155) Squashed 'buildres/csl/csl-styles/' changes from 8d69f16..201e022 Clarify the duplicates resolver dialog actions (JabRef#9140)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #9056
TODO
Automatically remove exact duplicatesbutton.Screenshots
ImportEntriesDialog (triggered when importing another library into the current library) and ImportHandler (triggered when pasting an entry from the clipboard)
The default DuplicateResolverDialog (triggered by choosing 'Find duplicates' from the menu)
Help button and Remove exact duplicates button visible
CHANGELOG.mddescribed in a way that is understandable for the average user (if applicable)