Skip to content

Citavi Importer - Import all knowledge items#9043

Merged
Siedlerchr merged 17 commits into
mainfrom
followUpCitativKnowledgeItems
Aug 13, 2022
Merged

Citavi Importer - Import all knowledge items#9043
Siedlerchr merged 17 commits into
mainfrom
followUpCitativKnowledgeItems

Conversation

@Siedlerchr

@Siedlerchr Siedlerchr commented Aug 11, 2022

Copy link
Copy Markdown
Member

Filter out empty strings and replace quot
Follow up from #9033

  • Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
  • Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

Comment thread src/main/java/org/jabref/model/database/BibDatabase.java Outdated
Filter out empty strings and replace quot
@Siedlerchr Siedlerchr force-pushed the followUpCitativKnowledgeItems branch from 2d5ef1d to 4ae2d73 Compare August 11, 2022 12:09
Comment thread src/main/java/org/jabref/logic/importer/fileformat/CitaviXmlImporter.java Outdated
Comment thread src/test/java/org/jabref/logic/importer/fileformat/CitaviXmlImporterTest.java Outdated
Comment thread src/test/java/org/jabref/logic/importer/fileformat/CitaviXmlImporterTest.java Outdated
@Siedlerchr Siedlerchr added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Aug 11, 2022
@ThiloteE ThiloteE changed the title Import all knowledge items Citavi Importer - Import all knowledge items Aug 11, 2022

@koppor koppor left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As co-author, I like it 😇

@Siedlerchr

Copy link
Copy Markdown
Member Author

I am waiting on feedback from ray-carpenter, so let's wait with merging a bit

…ledgeItems

* upstream/main:
  Fixed table update in eft preferences (#9051)
  Keep EOL setting at backups (#9048)
  ExternalFileTypes singleton refactor (#9044)
  Fix dead link (#9047)
  Fix performance regresssion (#9045)

# Conflicts:
#	CHANGELOG.md
…ref into followUpCitativKnowledgeItems

* 'followUpCitativKnowledgeItems' of github.com:JabRef/jabref:
@Siedlerchr

Copy link
Copy Markdown
Member Author

I've now included the quotation index and the type of the quotation as well. Based on the mapping:
#9025 (comment)

@koppor

koppor commented Aug 13, 2022

Copy link
Copy Markdown
Member

I like.

Future work should treat the quotation stuff as PDF highlights, shouldn't it? - This would enable "annotating" PDFs without altering the PDF. Similar as CloudRef does it. :)

@Siedlerchr

Copy link
Copy Markdown
Member Author

Yes, but we don't have a concept for storing pdf annotations in bibtex fields, they are just read and kept in memory while JabRef is open.

@koppor

koppor commented Aug 13, 2022

Copy link
Copy Markdown
Member

We could create a YAML file - as we are going to do at #7160 (comment).

@Siedlerchr Siedlerchr merged commit bd77d73 into main Aug 13, 2022
@Siedlerchr Siedlerchr deleted the followUpCitativKnowledgeItems branch August 13, 2022 19:03
Siedlerchr added a commit to JabRef/jabref-koppor that referenced this pull request Aug 14, 2022
* upstream/main: (31 commits)
  Citavi Importer - Import all knowledge items (JabRef#9043)
  Fixed table update in eft preferences (JabRef#9051)
  Keep EOL setting at backups (JabRef#9048)
  ExternalFileTypes singleton refactor (JabRef#9044)
  Fix dead link (JabRef#9047)
  Fix performance regresssion (JabRef#9045)
  Update javafx to 18.02
  import citavi knowledge items (JabRef#9033)
  Fix .gitattributes for CHANGELOG.md
  [GSOC22] - B - Implement merging fields in the three way merge UI (JabRef#9022)
  [GSOC22] - A - Implement a fully functional three way merge UI (JabRef#8945)
  Change button label from "Return to JabRef" to "Return to library" (JabRef#9039)
  Bump postgresql from 42.4.0 to 42.4.1 (JabRef#9036)
  Bump org.javamodularity.moduleplugin from 1.8.11 to 1.8.12 (JabRef#9037)
  Bump slf4j-api from 2.0.0-alpha7 to 2.0.0-beta1 (JabRef#9035)
  Bump slf4j-api from 2.0.0-alpha7 to 2.0.0-beta1 in /buildSrc (JabRef#9038)
  Update Gradle Wrapper from 7.5 to 7.5.1. (JabRef#9034)
  Refactor of DOI import failure dialog, import format reader and clipboard manager (JabRef#8839)
  Snapcraft and issue template
  Show development information\n\n+semver: minor
  ...
Siedlerchr added a commit that referenced this pull request Aug 21, 2022
* upstream/main:
  Citavi Importer - Import all knowledge items (#9043)
  Fixed table update in eft preferences (#9051)
  Keep EOL setting at backups (#9048)
  ExternalFileTypes singleton refactor (#9044)
  Fix dead link (#9047)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

component: import-load status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants