Skip to content

Autosave folder and checkbox is remembered#9000

Merged
calixtus merged 2 commits into
JabRef:mainfrom
m-mauersberger:remASDir
Jul 29, 2022
Merged

Autosave folder and checkbox is remembered#9000
calixtus merged 2 commits into
JabRef:mainfrom
m-mauersberger:remASDir

Conversation

@m-mauersberger

@m-mauersberger m-mauersberger commented Jul 28, 2022

Copy link
Copy Markdown
Contributor

With this changes, the autosave folder and tick in the shared database opening dialog is remembered for the next time. I introduced these two things as new attributes of SharedDatabasePreferences.

Fixes #7516.

Please check if this changes are as intended. I have seen that there are preference attributes for all other elements of the shared database opening dialog, but not for these two. Maybe there is a reason for that. But I think the new changes more convenient when you frequently open the shared database and want to synchronize the same BIB file everytime.

@m-mauersberger m-mauersberger marked this pull request as ready for review July 28, 2022 08:00
@Siedlerchr Siedlerchr requested a review from calixtus July 28, 2022 08:03
@ThiloteE ThiloteE added component: shared-database component: preferences status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers labels Jul 28, 2022
@calixtus

Copy link
Copy Markdown
Member

Seems right. SharedDbPrefs is not yet converted to the new pattern. So looks good to me. Thanks.

@calixtus calixtus merged commit bd8ede5 into JabRef:main Jul 29, 2022
Siedlerchr added a commit that referenced this pull request Aug 3, 2022
* upstream/main: (21 commits)
  New Crowdin updates (#9016)
  New Crowdin updates (#9013)
  try to gather more output from LO exception (#9002)
  Improve Automatic Field Editor Dialog (#8973)
  Update BST VM to Antlr4 (#8934)
  Support biblatex apa citation for legal entry types (#8966)
  Bump junit-jupiter from 5.8.2 to 5.9.0 (#9012)
  Bump lucene-core from 9.2.0 to 9.3.0 (#9009)
  Bump checkstyle from 10.3.1 to 10.3.2 (#9006)
  Bump appleboy/ssh-action from 0.1.4 to 0.1.5 (#9005)
  New translations JabRef_en.properties (Spanish) (#9003)
  Squashed 'buildres/csl/csl-locales/' changes from 55459cd79f..e637746677
  Squashed 'buildres/csl/csl-styles/' changes from 3d3573c..c750b6e
  Autosave folder and checkbox is remembered (#9000)
  New Crowdin updates (#8999)
  Sync group view mode and main table (#8993)
  Bump unoloader from 7.3.4 to 7.3.5 (#8996)
  Bump libreoffice from 7.3.4 to 7.3.5 (#8997)
  Bump java-diff-utils from 4.11 to 4.12 (#8998)
  Fix external group metadata changes are not merged (#8994)
  ...
Siedlerchr added a commit that referenced this pull request Aug 3, 2022
* upstream/main: (39 commits)
  New Crowdin updates (#9016)
  New Crowdin updates (#9013)
  try to gather more output from LO exception (#9002)
  Improve Automatic Field Editor Dialog (#8973)
  Update BST VM to Antlr4 (#8934)
  Support biblatex apa citation for legal entry types (#8966)
  Bump junit-jupiter from 5.8.2 to 5.9.0 (#9012)
  Bump lucene-core from 9.2.0 to 9.3.0 (#9009)
  Bump checkstyle from 10.3.1 to 10.3.2 (#9006)
  Bump appleboy/ssh-action from 0.1.4 to 0.1.5 (#9005)
  New translations JabRef_en.properties (Spanish) (#9003)
  Squashed 'buildres/csl/csl-locales/' changes from 55459cd79f..e637746677
  Squashed 'buildres/csl/csl-styles/' changes from 3d3573c..c750b6e
  Autosave folder and checkbox is remembered (#9000)
  New Crowdin updates (#8999)
  Sync group view mode and main table (#8993)
  Bump unoloader from 7.3.4 to 7.3.5 (#8996)
  Bump libreoffice from 7.3.4 to 7.3.5 (#8997)
  Bump java-diff-utils from 4.11 to 4.12 (#8998)
  Fix external group metadata changes are not merged (#8994)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

component: preferences component: shared-database status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Automatically saving shared library will not be remembered

4 participants