Fixes koppor/jabref#521 - Allow to drag&drop selected bib entries to other library tabs#8982
Merged
Merged
Conversation
…other drag'n'drop)
Siedlerchr
reviewed
Jul 16, 2022
Siedlerchr
approved these changes
Jul 16, 2022
Siedlerchr
left a comment
Member
There was a problem hiding this comment.
thanks for this PR! Codewise looks already good to me.
Before merging, a second maintainer needs to review your code as well
…ription) Co-authored-by: Christoph <siedlerkiller@gmail.com>
Contributor
Author
Thank you for your kindly review! |
Member
|
Thank you for the PR! We have a small nitpick that We could not update it for ourselves, because editing by maintainers is disabled:
We merge nevertheless and will rename later (at some time ^^). Thank you for the PR! |
Member
|
Rename happened at #8989 |
Siedlerchr
added a commit
to zkl-ai/jabref
that referenced
this pull request
Jul 19, 2022
…failure-dialog * upstream/main: Reworded t in pr (JabRef#8989) Fixed checkstyle (JabRef#8990) Fix RfcFetcherTest (JabRef#8988) Fixes JabRef#521 - Allow to drag&drop selected bib entries to other library tabs (JabRef#8982) # Conflicts: # src/main/java/org/jabref/gui/maintable/MainTable.java # src/test/java/org/jabref/logic/importer/fetcher/JstorFetcherTest.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed JabRef#521
by adding a new feature that allows to drag selected entries, and drop them to other opened inactive bib library tabs.
Behavior Description:
Now when dragging selected entries in main table, JabRef allows user to drop it on another opened library tab, and this item will be copied and added to the dropped library accordingly. Drop to current active tab is disallowed. If there're potential duplicated entries, JabRef will ask user to confirm and choose copy behavior (similar to ctrl-c/v copy and paste).
Screenshots for UI changes:
Checklist / TODOs :
CHANGELOG.mddescribed in a way that is understandable for the average user (if applicable)