Skip to content

Reviewdoc: Comment on PRs#8878

Merged
Siedlerchr merged 4 commits into
mainfrom
checkstyle-is-code-review
Jun 1, 2022
Merged

Reviewdoc: Comment on PRs#8878
Siedlerchr merged 4 commits into
mainfrom
checkstyle-is-code-review

Conversation

@koppor

@koppor koppor commented May 31, 2022

Copy link
Copy Markdown
Member

There are more and more pull requests coming in JabRef. A significant number of them does not follow our guidelines to setup a workspace.

The contributors do not check our failing tests and they should get instant feedback.

I checked comment-failure-action.
It will produce lots of similar comments at each run (quipper/comment-failure-action#224).
Therefore, I did not use it.

The solution is to let reviewdog create a review.

  • Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
  • Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

@ThiloteE ThiloteE added the dev: code-quality Issues related to code or architecture decisions label Jun 1, 2022
@Siedlerchr Siedlerchr merged commit 22c2bb5 into main Jun 1, 2022
@Siedlerchr Siedlerchr deleted the checkstyle-is-code-review branch June 1, 2022 15:21
Siedlerchr added a commit that referenced this pull request Jun 1, 2022
* upstream/main:
  Add an importer for Citavi backup files (#8848)
  Reviewdoc: Comment on PRs (#8878)
  Squashed 'buildres/csl/csl-styles/' changes from 649aac4..e740261
  Use JDK 15 text blocks to improve injected languages readability (#8874)
  Fix fetcher tests (#8877)
  Fix #8390 by allowing multiple group deletion for Remove groups > Kee… (#8875)
  Add restart warning on SSL configuration change (#8871)
  Update to lucene 9.2 (#8868)
  Fix for removing several groups deletes only one of them (#8801)
  Disable Write XMP Button in General tab of Entry-Editor when action is in progress (#8728)
  Bump jsoup from 1.14.3 to 1.15.1 (#8864)
  Bump unirest-java from 3.13.8 to 3.13.10 (#8869)
  Bump unoloader from 7.3.2 to 7.3.3 (#8863)
  Bump pascalgn/automerge-action from 0.15.2 to 0.15.3 (#8860)
  Bump classgraph from 4.8.146 to 4.8.147 (#8861)
  Bump mockito-core from 4.5.1 to 4.6.0 (#8862)
  Lucence dir checkers should only delete lucence dirs (#8854)
  Update README.md (#8858)
  Update adr.md
  Update adr.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dev: code-quality Issues related to code or architecture decisions

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants