adjust and add testcases for FileAnnotationViewModel#8830
Merged
Siedlerchr merged 2 commits intoMay 21, 2022
Conversation
calixtus
approved these changes
May 20, 2022
calixtus
left a comment
Member
There was a problem hiding this comment.
Seems correct and good to me.
Thanks
Siedlerchr
approved these changes
May 21, 2022
Siedlerchr
added a commit
to claell/jabref
that referenced
this pull request
May 21, 2022
…lick * upstream/main: Add Pubmed/Medline Query Transformer (JabRef#8818) adjust and add testcases for FileAnnotationViewModel (JabRef#8830) Append config instead of replacing (JabRef#8834) Fix eclipse config (JabRef#8835) Add Nemo file manager (JabRef#8831) Fix missing clear action on pressing esc within the "Filter groups" field (JabRef#8829) Update bouncycalse to new base version (JabRef#8827) add: add test cases for FileUtil (JabRef#8810) Restrict use of standard streams (JabRef#8816) updated 8802 (JabRef#8817)
Siedlerchr
added a commit
to Christina0114/jabref
that referenced
this pull request
May 22, 2022
* upstream/main: (109 commits) Fix right clicking a group and choosing "remove selected entries from this group" leads to error when Bibtex source tab is selected (JabRef#8821) Fix single identifier cannot be opened on click (JabRef#8838) Add Pubmed/Medline Query Transformer (JabRef#8818) adjust and add testcases for FileAnnotationViewModel (JabRef#8830) Append config instead of replacing (JabRef#8834) Fix eclipse config (JabRef#8835) Add Nemo file manager (JabRef#8831) Fix missing clear action on pressing esc within the "Filter groups" field (JabRef#8829) Update bouncycalse to new base version (JabRef#8827) add: add test cases for FileUtil (JabRef#8810) Restrict use of standard streams (JabRef#8816) updated 8802 (JabRef#8817) Bump pascalgn/automerge-action from 0.15.2 to 0.15.3 (JabRef#8803) Bump jackson-dataformat-yaml from 2.13.2 to 2.13.3 (JabRef#8804) Bump icu4j-charset from 70.1 to 71.1 (JabRef#8805) Fix notifications that overlap task bar (JabRef#8775) checkstye Default path for ssl key store is nested inside "JabRef" directory (JabRef#8796) Add log on disk (JabRef#8791) Fix for JabRef#8788 JabRef not showing contents of shared database library (JabRef#8793) ...
Siedlerchr
added a commit
to josepylee/jabref
that referenced
this pull request
May 22, 2022
* upstream/main: Fix right clicking a group and choosing "remove selected entries from this group" leads to error when Bibtex source tab is selected (JabRef#8821) Fix single identifier cannot be opened on click (JabRef#8838) Add Pubmed/Medline Query Transformer (JabRef#8818) adjust and add testcases for FileAnnotationViewModel (JabRef#8830) Append config instead of replacing (JabRef#8834) Fix eclipse config (JabRef#8835) Add Nemo file manager (JabRef#8831) Fix missing clear action on pressing esc within the "Filter groups" field (JabRef#8829)
Siedlerchr
added a commit
to fly-ing-fish/jabref
that referenced
this pull request
May 22, 2022
…-masked-characters#8787 * upstream/main: Add: Add test cases for non-default styles in CitationStyleTest (JabRef#8828) Open event log when clicking on collapsed notification (JabRef#8837) Fix right clicking a group and choosing "remove selected entries from this group" leads to error when Bibtex source tab is selected (JabRef#8821) Fix single identifier cannot be opened on click (JabRef#8838) Add Pubmed/Medline Query Transformer (JabRef#8818) adjust and add testcases for FileAnnotationViewModel (JabRef#8830) Append config instead of replacing (JabRef#8834) Fix eclipse config (JabRef#8835) Add Nemo file manager (JabRef#8831) Fix missing clear action on pressing esc within the "Filter groups" field (JabRef#8829) Update bouncycalse to new base version (JabRef#8827) add: add test cases for FileUtil (JabRef#8810) Restrict use of standard streams (JabRef#8816)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The code for removing newlines & hyphens before linebreaks is inconsistent and lacks test cases for the part of when annotation doesn't have LinkedFileAnnotation.
CHANGELOG.mddescribed in a way that is understandable for the average user (if applicable)