Skip to content

Introduce OpenLibraryFetcher (and remove OttoBibFetcher)#8700

Merged
Siedlerchr merged 12 commits into
mainfrom
addOpenLibrary
Apr 20, 2022
Merged

Introduce OpenLibraryFetcher (and remove OttoBibFetcher)#8700
Siedlerchr merged 12 commits into
mainfrom
addOpenLibrary

Conversation

@koppor

@koppor koppor commented Apr 19, 2022 •
edited
Loading

Copy link
Copy Markdown
Member

Fixes #8652

  • Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
  • Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

@koppor @Siedlerchr @calixtus
Introduce OpenLibraryFetcher (and remove OttoBibFetcher)
b4763e9 
Co-authored-by: Christoph <siedlerkiller@gmail.com>
Co-authored-by: Carl Christian Snethlage <50491877+calixtus@users.noreply.github.com>
@Siedlerchr Siedlerchr marked this pull request as ready for review April 19, 2022 21:51
@calixtus calixtus added status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers component: fetcher labels Apr 19, 2022
@koppor koppor added this to the v5.6 milestone Apr 19, 2022
@koppor

koppor commented Apr 19, 2022

Copy link
Copy Markdown
Member Author

Test case PdfMergeMetadataImporterTest > importWorksAsExpected() FAILED. Seems to be related to switch of the ISBN fetcher.

@a1819644

a1819644 commented Apr 20, 2022

Copy link
Copy Markdown

@koppor. Can my team have a look into this issue too? We are the student from Adelaide university.

@calixtus

calixtus commented Apr 20, 2022

Copy link
Copy Markdown
Member

I'm afraid this is not a real issue, but already an almost done pull request with some minor tweaks needed. You can of course take a look into, but expect this to be finished soon. So don't waste your efforts.

@a1819644

a1819644 commented Apr 20, 2022

Copy link
Copy Markdown

I'm afraid this is not a real issue, but already an almost done pull request with some minor tweaks needed. You can of course take a look into, but expect this to be finished soon. So don't waste your efforts.

Ohk i see. Thanks for the quick response

@calixtus

calixtus commented Apr 20, 2022

Copy link
Copy Markdown
Member

Maybe you would like to take a look at our list of good first issues: good first issue An issue intended for project-newcomers. Varies in difficulty.

@Siedlerchr Siedlerchr merged commit 51a1569 into main Apr 20, 2022
@Siedlerchr Siedlerchr deleted the addOpenLibrary branch April 20, 2022 21:53
Jonathan-Oliveira pushed a commit to Jonathan-Oliveira/jabref that referenced this pull request May 7, 2022
@koppor @Siedlerchr
@calixtus @Jonathan-Oliveira
Introduce OpenLibraryFetcher (and remove OttoBibFetcher) (JabRef#8700)
cc137ab 
* Introduce OpenLibraryFetcher (and remove OttoBibFetcher)

Co-authored-by: Christoph <siedlerkiller@gmail.com>
Co-authored-by: Carl Christian Snethlage <50491877+calixtus@users.noreply.github.com>

* Fix checkstyle

* Disable failing test

* Fix tests

* Remove requires at module-info

* Add support for "works" for parsing authors

* readd author to test

Co-authored-by: Christoph <siedlerkiller@gmail.com>
Co-authored-by: Carl Christian Snethlage <50491877+calixtus@users.noreply.github.com>
@koppor koppor mentioned this pull request Jun 13, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@calixtus calixtus calixtus approved these changes

Assignees

No one assigned

Labels

component: fetcher status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers

Projects

None yet

Milestone

v5.6

Development

Successfully merging this pull request may close these issues.

Change order of ISBN fetchers to improve fetching most complete information

4 participants

@koppor @a1819644 @calixtus @Siedlerchr