Skip to content

Cleanup: Escape $ signs #8698

Merged
koppor merged 14 commits into
JabRef:mainfrom
fly-ing-fish:fix-8673
Apr 20, 2022
Merged

Cleanup: Escape $ signs #8698
koppor merged 14 commits into
JabRef:mainfrom
fly-ing-fish:fix-8673

Conversation

@fly-ing-fish

@fly-ing-fish fly-ing-fish commented Apr 19, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor

Fixes #8673

  • Add cleanup action that adds a backslash in front of $
  • Add a hint in "Clone your forked repository on your local machine":
    note that placing jabref folder directly in the disk root directory may cause an error.

image

  • Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
  • Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

@fly-ing-fish
add 2
4940a26 
EscapeCurrencySymbolsFormatter and  EscapeCurrencySymbolsFormatterTest
@fly-ing-fish
Update Formatters.java
75689bc
@fly-ing-fish
Update Formatters.java
fef92f5
@fly-ing-fish
Update guidelines-for-setting-up-a-local-workspace.md
2f337c7 
Add a hint in "Clone your forked repository on your local machine" , 
Note that placing jabref folder directly in the disk root directory may cause an error.
@fly-ing-fish
Update EscapeCurrencySymbolsFormatterTest.java
e213676
@fly-ing-fish
update
32319a5
@Siedlerchr Siedlerchr changed the title Fix 8673 Cleanup: Escape $ signs Apr 19, 2022
koppor
koppor requested changes Apr 19, 2022
View reviewed changes
Comment thread src/main/java/org/jabref/logic/formatter/bibtexfields/EscapeCurrencySymbolsFormatter.java Outdated
Comment thread src/test/java/org/jabref/logic/formatter/bibtexfields/EscapeCurrencySymbolsFormatterTest.java Outdated
Comment thread src/main/java/org/jabref/logic/formatter/bibtexfields/EscapeCurrencySymbolsFormatter.java Outdated
@fly-ing-fish
update
47263d5 
update the name to Escape Dollager Sign and remove redundant \
@fly-ing-fish
Update JabRef_en.properties
4c37aa1 
add Escape\ dollar\ sign=Escape dollar sign
@fly-ing-fish fly-ing-fish marked this pull request as ready for review April 20, 2022 08:24
@fly-ing-fish fly-ing-fish requested a review from koppor April 20, 2022 08:53
@ThiloteE

ThiloteE commented Apr 20, 2022

Copy link
Copy Markdown
Member

I tested this pull-request. Looking good! Was able to backslash dollar signs.
When there was already a backslash in front of a dollar sign, it did NOT add another backslash.

koppor and others added 6 commits April 20, 2022 23:45
@koppor
Merge remote-tracking branch 'origin/main' into fix-8673
dd23aac
@koppor @Siedlerchr
@calixtus @ThiloteE
Add more test cases (and convert to parameterized tests)
ce04ff0 
Co-authored-by: Christoph <siedlerkiller@gmail.com>
Co-authored-by: Carl Christian Snethlage <50491877+calixtus@users.noreply.github.com>
Co-authored-by: ThiloteE <73715071+ThiloteE@users.noreply.github.com>
@koppor @Siedlerchr
@calixtus @ThiloteE
Add CHANGELOG.md entry (and fix a typo)
93f7dbc 
Co-authored-by: Christoph <siedlerkiller@gmail.com>
Co-authored-by: Carl Christian Snethlage <50491877+calixtus@users.noreply.github.com>
Co-authored-by: ThiloteE <73715071+ThiloteE@users.noreply.github.com>
@koppor @Siedlerchr
Compile fix
f60f032 
Co-authored-by: Christoph <siedlerkiller@gmail.com>
@koppor
Merge remote-tracking branch 'origin/main' into fix-8673
bf05fc0
@koppor
Fix parameterized test
f1dc23e
@koppor koppor merged commit 60c2f17 into JabRef:main Apr 20, 2022
Jonathan-Oliveira pushed a commit to Jonathan-Oliveira/jabref that referenced this pull request May 7, 2022
@fly-ing-fish @Jonathan-Oliveira
Cleanup: Escape $ signs (JabRef#8698)
f869694
@fly-ing-fish fly-ing-fish deleted the fix-8673 branch May 12, 2022 03:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@koppor koppor koppor approved these changes

Assignees

No one assigned

Labels

component: cleanup-ops component: unicode unicode related issues

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add cleanup action: "Make LaTeX ready: Escape $"

3 participants

@fly-ing-fish @ThiloteE @koppor