Skip to content

Refine code of ISBN fetcher tests#8693

Merged
Siedlerchr merged 1 commit into
mainfrom
refineIsbnFetcherTests
Apr 19, 2022
Merged

Refine code of ISBN fetcher tests#8693
Siedlerchr merged 1 commit into
mainfrom
refineIsbnFetcherTests

Conversation

@koppor

@koppor koppor commented Apr 18, 2022

Copy link
Copy Markdown
Member

While I was working on creating tests for ebook.de, I improved the code style of the tests.

  • Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
  • Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

@koppor koppor added the dev: code-quality Issues related to code or architecture decisions label Apr 18, 2022
@Mohamadi98 Mohamadi98 mentioned this pull request Apr 19, 2022
5 tasks
@Siedlerchr Siedlerchr merged commit 3611809 into main Apr 19, 2022
@Siedlerchr Siedlerchr deleted the refineIsbnFetcherTests branch April 19, 2022 17:26
Siedlerchr added a commit that referenced this pull request Apr 19, 2022
* upstream/main:
  Refine code of ISBN fetcher tests (#8693)
  Fight EOL issues by pinning LF for *.java and *.properties (#8690)
  Bump libreoffice from 7.3.1 to 7.3.2 (#8683)
  Bump classgraph from 4.8.143 to 4.8.146 (#8684)
  Bump unirest-java from 3.13.7 to 3.13.8 (#8686)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dev: code-quality Issues related to code or architecture decisions

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants