Skip to content

Add required modules to module-info.java#8692

Merged
Siedlerchr merged 3 commits into
mainfrom
refineModuleInfo
Apr 19, 2022
Merged

Add required modules to module-info.java#8692
Siedlerchr merged 3 commits into
mainfrom
refineModuleInfo

Conversation

@koppor

@koppor koppor commented Apr 18, 2022 •
edited
Loading

Copy link
Copy Markdown
Member

Needed to add two require statements to our module-info.java to get JabRef compiling again.

Quick fix, thus, I merge instantly.

  • Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
  • Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

@koppor

koppor commented Apr 18, 2022

Copy link
Copy Markdown
Member Author

Can't merge, because of following output:

Error: jdk.internal.org.objectweb.asm.MethodTooLargeException: Method too large: jdk/internal/module/SystemModules$all.moduleDescriptors ()[Ljava/lang/module/ModuleDescriptor;

Blocked by https://bugs.openjdk.java.net/browse/JDK-8240567.

@Siedlerchr
Merge remote-tracking branch 'upstream/main' into refineModuleInfo
c46b41a 
* upstream/main:
  Refine code of ISBN fetcher tests (#8693)
  Fight EOL issues by pinning LF for *.java and *.properties (#8690)
  Bump libreoffice from 7.3.1 to 7.3.2 (#8683)
  Bump classgraph from 4.8.143 to 4.8.146 (#8684)
  Bump unirest-java from 3.13.7 to 3.13.8 (#8686)
@Siedlerchr
add uses directive
c0899df
@Siedlerchr Siedlerchr merged commit 9cc52b3 into main Apr 19, 2022
@Siedlerchr Siedlerchr deleted the refineModuleInfo branch April 19, 2022 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@koppor @Siedlerchr