Skip to content

Save xmp data to new file and then copy it back#8656

Merged
Siedlerchr merged 3 commits into
mainfrom
fixXMP
Apr 10, 2022
Merged

Save xmp data to new file and then copy it back#8656
Siedlerchr merged 3 commits into
mainfrom
fixXMP

Conversation

@Siedlerchr

@Siedlerchr Siedlerchr commented Apr 9, 2022

Copy link
Copy Markdown
Member

Fixes #8655

No changelog necessary as this was most likely introduced in d98a603

  • Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
  • Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

@Siedlerchr Siedlerchr added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Apr 9, 2022
@ThiloteE

ThiloteE commented Apr 9, 2022

Copy link
Copy Markdown
Member

Looking good! Tried it and have not encountered any negative side-effects (yet)! 👍

Edit:

What I did: I wrote XMP metadata to pdf. It worked. pdf file is not corrupted anymore and can be opened with foxitreader. Used exiftool to check if metadata was attached to the pdf: yes, it was. Tried importing the pdf into jabref (with and without grobid) and both import methods worked. Metadata was parsed.

@ThiloteE

ThiloteE commented Apr 9, 2022

Copy link
Copy Markdown
Member

Thanks Christoph!

Siedlerchr and others added 2 commits April 9, 2022 19:22
… rights

Co-authored-by: Christoph <siedlerkiller@gmail.com>
@Siedlerchr Siedlerchr merged commit b229618 into main Apr 10, 2022
@Siedlerchr Siedlerchr deleted the fixXMP branch April 10, 2022 19:44
@koppor koppor mentioned this pull request Apr 10, 2022
6 tasks
Siedlerchr added a commit that referenced this pull request Apr 11, 2022
…-0.3.0' of github.com:JabRef/jabref into dependabot/gradle/com.github.tomtung-latex2unicode_2.12-0.3.0

* 'dependabot/gradle/com.github.tomtung-latex2unicode_2.12-0.3.0' of github.com:JabRef/jabref:
  try version 0.3.1
  Save xmp data to new file and then copy it back (#8656)
  Adding notifications when writing metadata to pdfs (#8647)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Jabref corrupts PDF file when writing XMP metadata to linked PDF

3 participants